Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1961373003: [heap] Do not invoke GC to make heap iterable. (Closed)

Created:
4 years, 7 months ago by Hannes Payer (out of office)
Modified:
4 years, 7 months ago
Reviewers:
ulan, Yang
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Do not invoke GC to make heap iterable. Remove kMakeHeapIterableMask since the heap is always iterable. BUG=chromium:580959 LOG=n Committed: https://crrev.com/7c1cac4888a248fda3fa6de3624f32a6babb37e9 Cr-Commit-Position: refs/heads/master@{#36333}

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -50 lines) Patch
M src/debug/debug.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/heap.h View 4 chunks +2 lines, -10 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +3 lines, -17 lines 0 comments Download
M src/log.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 1 2 2 chunks +6 lines, -8 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-log.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/debug-referenced-by.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
Hannes Payer (out of office)
In a follow-up CL, I will change the heap iterate to be aware of the ...
4 years, 7 months ago (2016-05-10 13:57:53 UTC) #3
ulan
lgtm with comments https://codereview.chromium.org/1961373003/diff/20001/src/profiler/heap-snapshot-generator.cc File src/profiler/heap-snapshot-generator.cc (right): https://codereview.chromium.org/1961373003/diff/20001/src/profiler/heap-snapshot-generator.cc#newcode481 src/profiler/heap-snapshot-generator.cc:481: heap_->CollectAllGarbage(Heap::kNoGCFlags, We probably need to about ...
4 years, 7 months ago (2016-05-10 14:05:42 UTC) #4
Yang
lgtm
4 years, 7 months ago (2016-05-10 14:07:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961373003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961373003/40001
4 years, 7 months ago (2016-05-18 14:49:58 UTC) #8
Hannes Payer (out of office)
https://codereview.chromium.org/1961373003/diff/20001/src/profiler/heap-snapshot-generator.cc File src/profiler/heap-snapshot-generator.cc (right): https://codereview.chromium.org/1961373003/diff/20001/src/profiler/heap-snapshot-generator.cc#newcode481 src/profiler/heap-snapshot-generator.cc:481: heap_->CollectAllGarbage(Heap::kNoGCFlags, On 2016/05/10 at 14:05:42, ulan wrote: > We ...
4 years, 7 months ago (2016-05-18 14:50:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/5915) v8_linux_dbg_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 7 months ago (2016-05-18 15:16:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961373003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961373003/80001
4 years, 7 months ago (2016-05-18 18:00:15 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-18 18:02:20 UTC) #15
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/7c1cac4888a248fda3fa6de3624f32a6babb37e9 Cr-Commit-Position: refs/heads/master@{#36333}
4 years, 7 months ago (2016-05-18 18:03:57 UTC) #17
Michael Achenbach
4 years, 7 months ago (2016-05-18 19:21:44 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1987363002/ by machenbach@chromium.org.

The reason for reverting is: Breaks
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/....

Powered by Google App Engine
This is Rietveld 408576698