Clamp, not cast length value in CSS length conversion

Clamp, not cast length value in CSS length conversion

computeLength() in CSSPrimitiveValue was returning only static_cast'ed,
but not clamped values, leading to float overflows in font and Skia code
down the line.

The test result needs to be compared visually as the crash does not trigger
using dumpAsText().

BUG=610645
TEST=fast/text/letter-spacing-crash.html

Committed: https://crrev.com/6dd652af9ab5089938ce8c24513b4a768d0c5b45
Cr-Commit-Position: refs/heads/master@{#394390}

[drott, 2016-05-18 10:52:44]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[drott, 2016-05-18 10:52:56]

drott@chromium.org changed reviewers:
+ fmalita@chromium.org, timloh@chromium.org

[commit-bot: I haz the power, 2016-05-18 10:53:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1987223002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1987223002/20001

[drott, 2016-05-18 10:54:16]

PTAL

[rune, 2016-05-18 11:22:17]

rune@opera.com changed reviewers:
+ rune@opera.com

[rune, 2016-05-18 11:22:18]

lgtm with test nit:

If possible, I think we prefer text output to html reference as comparing the
text is cheaper than comparing screenshots.

[commit-bot: I haz the power, 2016-05-18 11:57:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 11:57:36]

Dry run: This issue passed the CQ dry run.

[drott, 2016-05-18 11:59:08]

On 2016/05/18 at 11:22:18, rune wrote:
> lgtm with test nit:
> 
> If possible, I think we prefer text output to html reference as comparing the
text is cheaper than comparing screenshots.

You mean, dumpAsText()? If that's what you mean, unfortunately, the crash is not
triggered in this mode.

[rune, 2016-05-18 12:11:14]

On 2016/05/18 11:59:08, drott wrote:
> On 2016/05/18 at 11:22:18, rune wrote:
> > lgtm with test nit:
> > 
> > If possible, I think we prefer text output to html reference as comparing
the
> text is cheaper than comparing screenshots.
> 
> You mean, dumpAsText()? If that's what you mean, unfortunately, the crash is
not
> triggered in this mode.

Yes, that's what I meant.

[drott, 2016-05-18 12:16:16]

The CQ bit was checked by drott@chromium.org

[commit-bot: I haz the power, 2016-05-18 12:16:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1987223002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1987223002/20001

[drott, 2016-05-18 12:17:48]

Description was changed from

==========
Clamp, not cast length value in CSS length conversion

computeLength() in CSSPrimitiveValue was returning only static_cast'ed,
but not clamped values, leading to float overflows in font and Skia code
down the line.

BUG=610645
==========

to

==========
Clamp, not cast length value in CSS length conversion

computeLength() in CSSPrimitiveValue was returning only static_cast'ed,
but not clamped values, leading to float overflows in font and Skia code
down the line.

The test result needs to be compared visually as the crash does not trigger
using dumpAsText().

BUG=610645
TEST=fast/text/letter-spacing-crash.html
==========

[drott, 2016-05-18 12:18:13]

On 2016/05/18 at 12:11:14, rune wrote:
> On 2016/05/18 11:59:08, drott wrote:
> > On 2016/05/18 at 11:22:18, rune wrote:
> > > lgtm with test nit:
> > > 
> > > If possible, I think we prefer text output to html reference as comparing
the
> > text is cheaper than comparing screenshots.
> > 
> > You mean, dumpAsText()? If that's what you mean, unfortunately, the crash is
not
> > triggered in this mode.
> 
> Yes, that's what I meant.

Okay, I updated the CL description accordingly.

[commit-bot: I haz the power, 2016-05-18 12:19:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-18 12:21:27]

Description was changed from

==========
Clamp, not cast length value in CSS length conversion

computeLength() in CSSPrimitiveValue was returning only static_cast'ed,
but not clamped values, leading to float overflows in font and Skia code
down the line.

The test result needs to be compared visually as the crash does not trigger
using dumpAsText().

BUG=610645
TEST=fast/text/letter-spacing-crash.html
==========

to

==========
Clamp, not cast length value in CSS length conversion

computeLength() in CSSPrimitiveValue was returning only static_cast'ed,
but not clamped values, leading to float overflows in font and Skia code
down the line.

The test result needs to be compared visually as the crash does not trigger
using dumpAsText().

BUG=610645
TEST=fast/text/letter-spacing-crash.html

Committed: https://crrev.com/6dd652af9ab5089938ce8c24513b4a768d0c5b45
Cr-Commit-Position: refs/heads/master@{#394390}
==========

[commit-bot: I haz the power, 2016-05-18 12:21:28]

Patchset 2 (id:??) landed as
https://crrev.com/6dd652af9ab5089938ce8c24513b4a768d0c5b45
Cr-Commit-Position: refs/heads/master@{#394390}