third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp - Issue 1987223002: Clamp, not cast length value in CSS length conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

Issue 1987223002: Clamp, not cast length value in CSS length conversion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove spurious newline Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

index 3a438d43ce83260dd2ce56fef67cceba215110d6..deb1d2df1d9a6e44880bec9f933427d584f8d1ab 100644

--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

@@ -357,7 +357,7 @@ template<> unsigned short CSSPrimitiveValue::computeLength(const CSSToLengthConv

template<> float CSSPrimitiveValue::computeLength(const CSSToLengthConversionData& conversionData) const

{

- return static_cast<float>(computeLengthDouble(conversionData));

+ return clampTo<float>(computeLengthDouble(conversionData));

}

template<> double CSSPrimitiveValue::computeLength(const CSSToLengthConversionData& conversionData) const

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/text/letter-spacing-crash-expected.html ('k') | no next file » | no next file with comments »