Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 1987203002: Remove OwnPtr::release(). (Closed)

Created:
4 years, 7 months ago by Yuta Kitamura
Modified:
4 years, 7 months ago
Reviewers:
*haraken, *tzik
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, Mikhail, blink-reviews-wtf_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove OwnPtr::release(). Having OwnPtr::release() can be confusing when we convert OwnPtrs to std::unique_ptrs, because std::unique_ptr also has release() member function with a different meaning. Existing uses of OwnPtr::release() are already mostly removed; this patch takes care of release() calls from recent changes, and actually removes the method. BUG=611660 Committed: https://crrev.com/0030f9c2a1dec3f165d6a23aff64292fec2067f1 Cr-Commit-Position: refs/heads/master@{#394722}

Patch Set 1 #

Patch Set 2 : Fix a few platform-specific files. #

Patch Set 3 : Merge with trunk for landing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M third_party/WebKit/Source/build/scripts/templates/MakeQualifiedNames.cpp.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/mac/FontCacheMac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/OwnPtr.h View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987203002/1
4 years, 7 months ago (2016-05-18 07:46:24 UTC) #2
Yuta Kitamura
Note: I sent a PSA to blink-dev, and will wait for feedbacks until tomorrow before ...
4 years, 7 months ago (2016-05-18 07:48:24 UTC) #6
haraken
LGTM assuming there is no objection on the PSA.
4 years, 7 months ago (2016-05-18 07:49:43 UTC) #7
tzik
lgtm
4 years, 7 months ago (2016-05-18 07:54:34 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/150042)
4 years, 7 months ago (2016-05-18 08:13:18 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987203002/20001
4 years, 7 months ago (2016-05-18 09:42:54 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-18 10:57:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987203002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987203002/40001
4 years, 7 months ago (2016-05-19 07:53:43 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-19 09:15:27 UTC) #19
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 09:16:32 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0030f9c2a1dec3f165d6a23aff64292fec2067f1
Cr-Commit-Position: refs/heads/master@{#394722}

Powered by Google App Engine
This is Rietveld 408576698