third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp - Issue 1987203002: Remove OwnPtr::release().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

Issue 1987203002: Remove OwnPtr::release(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge with trunk for landing. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp b/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

index af366abdcace41ae2e762def5b7d7d84a7ce1154..d402f5960793376bf611efb430c5bd3badd05979 100644

--- a/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

+++ b/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

@@ -428,7 +428,7 @@ PassOwnPtr<FetchDataConsumerHandle> BodyStreamBuffer::releaseHandle()

// We need to call these before calling closeAndLockAndDisturb.

const bool isClosed = isStreamClosed();

const bool isErrored = isStreamErrored();

- OwnPtr<FetchDataConsumerHandle> handle = m_handle.release();

+ OwnPtr<FetchDataConsumerHandle> handle = std::move(m_handle);

closeAndLockAndDisturb();