Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 1987173002: Video Player: Support Media Router to cast Drive videos. (Closed)

Created:
4 years, 7 months ago by fukino
Modified:
4 years, 7 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, posciak+watch_chromium.org, chromium-apps-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Video Player: Support Media Router to cast Drive videos. This CL includes following changes to support both media router and legacy cast extensions to cast Drive video. - Added media router's component extensions to the cast extension list we use. - when we use media router, we use a cast button which requests a cast session via shared cast dialog, instead of dropdown cast menu button . This CL includes some minor bug fixes. (Added inline comments for them) BUG=605390 TEST=enable media-router from chrome://flags and cast video from video player. Committed: https://crrev.com/54e8895f6205ab1486db3a15e66b8832f12aa541 Cr-Commit-Position: refs/heads/master@{#394737}

Patch Set 1 #

Total comments: 9

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -15 lines) Patch
M ui/file_manager/externs/chrome_cast.js View 1 chunk +7 lines, -1 line 0 comments Download
M ui/file_manager/video_player/css/media_controls.css View 2 chunks +6 lines, -3 lines 0 comments Download
M ui/file_manager/video_player/js/cast/cast_extension_discoverer.js View 1 chunk +4 lines, -3 lines 0 comments Download
M ui/file_manager/video_player/js/cast/cast_video_element.js View 1 chunk +3 lines, -1 line 0 comments Download
M ui/file_manager/video_player/js/cast/caster.js View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/file_manager/video_player/js/media_controls.js View 2 chunks +5 lines, -1 line 0 comments Download
M ui/file_manager/video_player/js/video_player.js View 1 6 chunks +74 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
fukino
Yoshiki san, could you take a look? Thanks! https://codereview.chromium.org/1987173002/diff/1/ui/file_manager/video_player/js/cast/cast_video_element.js File ui/file_manager/video_player/js/cast/cast_video_element.js (right): https://codereview.chromium.org/1987173002/diff/1/ui/file_manager/video_player/js/cast/cast_video_element.js#newcode353 ui/file_manager/video_player/js/cast/cast_video_element.js:353: error.code ...
4 years, 7 months ago (2016-05-18 05:02:21 UTC) #4
yoshiki
lgtm with nits https://codereview.chromium.org/1987173002/diff/1/ui/file_manager/externs/chrome_cast.js File ui/file_manager/externs/chrome_cast.js (right): https://codereview.chromium.org/1987173002/diff/1/ui/file_manager/externs/chrome_cast.js#newcode584 ui/file_manager/externs/chrome_cast.js:584: nit: remove a line. https://codereview.chromium.org/1987173002/diff/1/ui/file_manager/video_player/js/video_player.js File ...
4 years, 7 months ago (2016-05-19 07:23:37 UTC) #5
fukino
Thank you!! https://codereview.chromium.org/1987173002/diff/1/ui/file_manager/externs/chrome_cast.js File ui/file_manager/externs/chrome_cast.js (right): https://codereview.chromium.org/1987173002/diff/1/ui/file_manager/externs/chrome_cast.js#newcode584 ui/file_manager/externs/chrome_cast.js:584: On 2016/05/19 07:23:37, yoshiki wrote: > nit: ...
4 years, 7 months ago (2016-05-19 08:11:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987173002/20001
4 years, 7 months ago (2016-05-19 08:29:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/177257)
4 years, 7 months ago (2016-05-19 08:51:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987173002/20001
4 years, 7 months ago (2016-05-19 11:22:11 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-19 11:25:59 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 11:27:45 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/54e8895f6205ab1486db3a15e66b8832f12aa541
Cr-Commit-Position: refs/heads/master@{#394737}

Powered by Google App Engine
This is Rietveld 408576698