Video Player: Support Media Router to cast Drive videos.

Video Player: Support Media Router to cast Drive videos.

This CL includes following changes to support both media router and legacy cast extensions to cast Drive video.
- Added media router's component extensions to the cast extension list we use.
- when we use media router, we use a cast button which requests a cast session via shared cast dialog, instead of dropdown cast menu button .
This CL includes some minor bug fixes. (Added inline comments for them)

BUG=605390
TEST=enable media-router from chrome://flags and cast video from video player.

Committed: https://crrev.com/54e8895f6205ab1486db3a15e66b8832f12aa541
Cr-Commit-Position: refs/heads/master@{#394737}

[fukino, 2016-05-18 04:54:59]

Description was changed from

==========
Video Player: Support Media Router to cast Drive videos.

BUG=605390
TEST=enable media-router from chrome://flags and cast video from video player.
==========

to

==========
Video Player: Support Media Router to cast Drive videos.

When we use media router and presentation API, we shows shared dialog to select
receivers instead of dropdown menu button.
This CL adds media router component extensions 

This CL includes following changes to support both media router and legacy cast
extensions to cast Drive video.
- Added media router's component extensions to the cast extension list we use.
- when we use media router, we use a cast button which requests a cast session
via shared cast dialog, instead of dropdown cast menu button .
This CL includes some minor bug fixes. (Added inline comments for them)

BUG=605390
TEST=enable media-router from chrome://flags and cast video from video player.
==========

[fukino, 2016-05-18 04:55:17]

Description was changed from

==========
Video Player: Support Media Router to cast Drive videos.

When we use media router and presentation API, we shows shared dialog to select
receivers instead of dropdown menu button.
This CL adds media router component extensions 

This CL includes following changes to support both media router and legacy cast
extensions to cast Drive video.
- Added media router's component extensions to the cast extension list we use.
- when we use media router, we use a cast button which requests a cast session
via shared cast dialog, instead of dropdown cast menu button .
This CL includes some minor bug fixes. (Added inline comments for them)

BUG=605390
TEST=enable media-router from chrome://flags and cast video from video player.
==========

to

==========
Video Player: Support Media Router to cast Drive videos.

This CL includes following changes to support both media router and legacy cast
extensions to cast Drive video.
- Added media router's component extensions to the cast extension list we use.
- when we use media router, we use a cast button which requests a cast session
via shared cast dialog, instead of dropdown cast menu button .
This CL includes some minor bug fixes. (Added inline comments for them)

BUG=605390
TEST=enable media-router from chrome://flags and cast video from video player.
==========

[fukino, 2016-05-18 05:02:21]

fukino@chromium.org changed reviewers:
+ yoshiki@chromium.org

[fukino, 2016-05-18 05:02:21]

Yoshiki san, could you take a look? Thanks!

https://codereview.chromium.org/1987173002/diff/1/ui/file_manager/video_playe...
File ui/file_manager/video_player/js/cast/cast_video_element.js (right):

https://codereview.chromium.org/1987173002/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/js/cast/cast_video_element.js:353: error.code !==
chrome.cast.ErrorCode.INVALID_PARAMETER) {
bug fix: error code can be INVALID_PARAMETER as well as SESSION_ERROR when the
session is already closed.

https://codereview.chromium.org/1987173002/diff/1/ui/file_manager/video_playe...
File ui/file_manager/video_player/js/video_player.js (right):

https://codereview.chromium.org/1987173002/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/js/video_player.js:513: if
(this.currentSession_.status === chrome.cast.SessionStatus.CONNECTED)
bug fix: We should not request stop() if the current session is not connected to
receiver.

https://codereview.chromium.org/1987173002/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/js/video_player.js:756: // Loads the current video
in local player.
bug fix: we need to switch to local player even when the cast session is
terminated without any user operation in video player. (e.g. terminated by other
apps which tries to use the receiver).

[yoshiki, 2016-05-19 07:23:37]

lgtm with nits

https://codereview.chromium.org/1987173002/diff/1/ui/file_manager/externs/chr...
File ui/file_manager/externs/chrome_cast.js (right):

https://codereview.chromium.org/1987173002/diff/1/ui/file_manager/externs/chr...
ui/file_manager/externs/chrome_cast.js:584: 
nit: remove a line.

https://codereview.chromium.org/1987173002/diff/1/ui/file_manager/video_playe...
File ui/file_manager/video_player/js/video_player.js (right):

https://codereview.chromium.org/1987173002/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/js/video_player.js:513: if
(this.currentSession_.status === chrome.cast.SessionStatus.CONNECTED)
On 2016/05/18 05:02:21, fukino wrote:
> bug fix: We should not request stop() if the current session is not connected
to
> receiver.

nit: Please add a comment for that.

https://codereview.chromium.org/1987173002/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/js/video_player.js:667: * visibility of the cast
button..
nit: JSdoc for the argument.

[fukino, 2016-05-19 08:11:06]

Thank you!!

https://codereview.chromium.org/1987173002/diff/1/ui/file_manager/externs/chr...
File ui/file_manager/externs/chrome_cast.js (right):

https://codereview.chromium.org/1987173002/diff/1/ui/file_manager/externs/chr...
ui/file_manager/externs/chrome_cast.js:584: 
On 2016/05/19 07:23:37, yoshiki wrote:
> nit: remove a line.

In this file, it looks consistent to have 2 blank links for top-level blocks, so
let me keep this line.

https://codereview.chromium.org/1987173002/diff/1/ui/file_manager/video_playe...
File ui/file_manager/video_player/js/video_player.js (right):

https://codereview.chromium.org/1987173002/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/js/video_player.js:513: if
(this.currentSession_.status === chrome.cast.SessionStatus.CONNECTED)
On 2016/05/19 07:23:37, yoshiki wrote:
> On 2016/05/18 05:02:21, fukino wrote:
> > bug fix: We should not request stop() if the current session is not
connected
> to
> > receiver.
> 
> nit: Please add a comment for that.

Done.

https://codereview.chromium.org/1987173002/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/js/video_player.js:667: * visibility of the cast
button..
On 2016/05/19 07:23:37, yoshiki wrote:
> nit: JSdoc for the argument.

Done.

[fukino, 2016-05-19 08:29:14]

The CQ bit was checked by fukino@chromium.org

[fukino, 2016-05-19 08:29:15]

The patchset sent to the CQ was uploaded after l-g-t-m from yoshiki@chromium.org
Link to the patchset: https://codereview.chromium.org/1987173002/#ps20001
(title: "Address review comments.")

[commit-bot: I haz the power, 2016-05-19 08:29:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1987173002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1987173002/20001

[commit-bot: I haz the power, 2016-05-19 08:51:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 08:51:38]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fukino, 2016-05-19 11:21:55]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2016-05-19 11:22:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1987173002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1987173002/20001

[commit-bot: I haz the power, 2016-05-19 11:25:58]

Description was changed from

==========
Video Player: Support Media Router to cast Drive videos.

This CL includes following changes to support both media router and legacy cast
extensions to cast Drive video.
- Added media router's component extensions to the cast extension list we use.
- when we use media router, we use a cast button which requests a cast session
via shared cast dialog, instead of dropdown cast menu button .
This CL includes some minor bug fixes. (Added inline comments for them)

BUG=605390
TEST=enable media-router from chrome://flags and cast video from video player.
==========

to

==========
Video Player: Support Media Router to cast Drive videos.

This CL includes following changes to support both media router and legacy cast
extensions to cast Drive video.
- Added media router's component extensions to the cast extension list we use.
- when we use media router, we use a cast button which requests a cast session
via shared cast dialog, instead of dropdown cast menu button .
This CL includes some minor bug fixes. (Added inline comments for them)

BUG=605390
TEST=enable media-router from chrome://flags and cast video from video player.
==========

[commit-bot: I haz the power, 2016-05-19 11:25:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-19 11:27:44]

Description was changed from

==========
Video Player: Support Media Router to cast Drive videos.

This CL includes following changes to support both media router and legacy cast
extensions to cast Drive video.
- Added media router's component extensions to the cast extension list we use.
- when we use media router, we use a cast button which requests a cast session
via shared cast dialog, instead of dropdown cast menu button .
This CL includes some minor bug fixes. (Added inline comments for them)

BUG=605390
TEST=enable media-router from chrome://flags and cast video from video player.
==========

to

==========
Video Player: Support Media Router to cast Drive videos.

This CL includes following changes to support both media router and legacy cast
extensions to cast Drive video.
- Added media router's component extensions to the cast extension list we use.
- when we use media router, we use a cast button which requests a cast session
via shared cast dialog, instead of dropdown cast menu button .
This CL includes some minor bug fixes. (Added inline comments for them)

BUG=605390
TEST=enable media-router from chrome://flags and cast video from video player.

Committed: https://crrev.com/54e8895f6205ab1486db3a15e66b8832f12aa541
Cr-Commit-Position: refs/heads/master@{#394737}
==========

[commit-bot: I haz the power, 2016-05-19 11:27:45]

Patchset 2 (id:??) landed as
https://crrev.com/54e8895f6205ab1486db3a15e66b8832f12aa541
Cr-Commit-Position: refs/heads/master@{#394737}