ui/file_manager/video_player/js/cast/cast_video_element.js - Issue 1987173002: Video Player: Support Media Router to cast Drive videos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/video_player/js/cast/cast_video_element.js

Issue 1987173002: Video Player: Support Media Router to cast Drive videos. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/video_player/js/cast/cast_extension_discoverer.js ('k') | ui/file_manager/video_player/js/cast/caster.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/video_player/js/cast/cast_video_element.js

diff --git a/ui/file_manager/video_player/js/cast/cast_video_element.js b/ui/file_manager/video_player/js/cast/cast_video_element.js

index 0aa1f3fc5c18c4961a2a8550c6fef9a1c65398ad..700c8233b51ff08fe409d7400f22270e3c0882de 100644

--- a/ui/file_manager/video_player/js/cast/cast_video_element.js

+++ b/ui/file_manager/video_player/js/cast/cast_video_element.js

@@ -349,8 +349,10 @@ CastVideoElement.prototype = /** @struct */ {

function() {},

function(error) {

// Ignores session error, since session may already be closed.

- if (error.code !== chrome.cast.ErrorCode.SESSION_ERROR)

+ if (error.code !== chrome.cast.ErrorCode.SESSION_ERROR &&

+ error.code !== chrome.cast.ErrorCode.INVALID_PARAMETER) {

this.onCastCommandError_(error);

+ }

}.wrap(this));

this.castMedia_.removeUpdateListener(this.onCastMediaUpdatedBound_);