Add DOMAIN_MISMATCH message end to end

remoting/protocol/jingle_messages.cc

Index: remoting/protocol/jingle_messages.cc
diff --git a/remoting/protocol/jingle_messages.cc b/remoting/protocol/jingle_messages.cc
index bc8846a0e3833bef62fa6f3fd8ec1b554d4f1577..b52a297c2c221de2900ebc60f25f8eef285a4510 100644
--- a/remoting/protocol/jingle_messages.cc
+++ b/remoting/protocol/jingle_messages.cc
@@ -44,6 +44,7 @@ const NameMapElement<JingleMessage::ActionType> kActionTypes[] = {
 const NameMapElement<JingleMessage::Reason> kReasons[] = {
   { JingleMessage::SUCCESS, "success" },
   { JingleMessage::DECLINE, "decline" },
+  { JingleMessage::DOMAIN_MISMATCH, "domain-mismatch" },

[Sergey Ulanov, 2016/05/20 00:07:05]

The XMPP spec defines list of the reasons, and "domain-mismatch" isn't there.
Technically this error is closed to <security-error/> reason, but I don't think
we want to use it here either.
What I suggest doing instead is adding a separate tag in the <reason>, to
specify an error code from error.h. So generated reason would look as follows:
 <jingle:reason>
   <jingle:decline/>
   <crd:error-code>DOMAIN_MISTMATCH</crd:error-code>
 </jingle:reason>

(notice different namespace for error-code)
Then going forward on the receiver side we may even ignore the offical reason
and just use <error-code> when it's present.
This will scale better for adding new error codes going forward as we won't need
to add new reason for each new error code.

[kelvinp, 2016/05/20 22:44:12]

I don't think you have addressed Sergey's comment here.

   { JingleMessage::CANCEL, "cancel" },
   { JingleMessage::EXPIRED, "expired" },
   { JingleMessage::GENERAL_ERROR, "general-error" },