Add DOMAIN_MISMATCH message end to end

remoting/protocol/jingle_messages.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/jingle_messages.h"
 
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 #include "remoting/base/constants.h"
 #include "remoting/protocol/content_description.h"
@@ skipping 26 matching lines @@
   { JingleMessage::SESSION_INITIATE, "session-initiate" },
   { JingleMessage::SESSION_ACCEPT, "session-accept" },
   { JingleMessage::SESSION_TERMINATE, "session-terminate" },
   { JingleMessage::SESSION_INFO, "session-info" },
   { JingleMessage::TRANSPORT_INFO, "transport-info" },
 };
 
 const NameMapElement<JingleMessage::Reason> kReasons[] = {
   { JingleMessage::SUCCESS, "success" },
   { JingleMessage::DECLINE, "decline" },
+  { JingleMessage::DOMAIN_MISMATCH, "domain-mismatch" },

[Sergey Ulanov, 2016/05/20 00:07:05]

The XMPP spec defines list of the reasons, and "domain-mismatch" isn't there.
Technically this error is closed to <security-error/> reason, but I don't think
we want to use it here either.
What I suggest doing instead is adding a separate tag in the <reason>, to
specify an error code from error.h. So generated reason would look as follows:
 <jingle:reason>
   <jingle:decline/>
   <crd:error-code>DOMAIN_MISTMATCH</crd:error-code>
 </jingle:reason>

(notice different namespace for error-code)
Then going forward on the receiver side we may even ignore the offical reason
and just use <error-code> when it's present.
This will scale better for adding new error codes going forward as we won't need
to add new reason for each new error code.

[kelvinp, 2016/05/20 22:44:12]

I don't think you have addressed Sergey's comment here.

   { JingleMessage::CANCEL, "cancel" },
   { JingleMessage::EXPIRED, "expired" },
   { JingleMessage::GENERAL_ERROR, "general-error" },
   { JingleMessage::FAILED_APPLICATION, "failed-application" },
   { JingleMessage::INCOMPATIBLE_PARAMETERS, "incompatible-parameters" },
 };
 
 bool ParseIceCredentials(const buzz::XmlElement* element,
                          IceTransportInfo::IceCredentials* credentials) {
   DCHECK(element->Name() == QName(kIceTransportNamespace, "credentials"));
@@ skipping 432 matching lines @@
     result->AddElement(FormatIceCredentials(credentials));
   }
   for (const NamedCandidate& candidate : candidates) {
     result->AddElement(FormatIceCandidate(candidate));
   }
   return result;
 }
 
 }  // namespace protocol
 }  // namespace remoting