Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1987153002: Account for empty stack trace with non-empty async chain in V8Initializer. (Closed)

Created:
4 years, 7 months ago by dgozman
Modified:
4 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Account for empty stack trace with non-empty async chain in V8Initializer. Existing test inspector/console/console-message-contains-async-stack.html covers this. BUG=611926 Committed: https://crrev.com/b3f5671fe9436df46c470f35230bffe0a77fbb0d Cr-Commit-Position: refs/heads/master@{#394550}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dgozman
Could you please take a look?
4 years, 7 months ago (2016-05-18 01:56:43 UTC) #2
pfeldman
lgtm
4 years, 7 months ago (2016-05-18 05:10:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987153002/1
4 years, 7 months ago (2016-05-18 05:43:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/192202)
4 years, 7 months ago (2016-05-18 06:23:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987153002/1
4 years, 7 months ago (2016-05-18 20:22:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 21:16:06 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 21:18:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3f5671fe9436df46c470f35230bffe0a77fbb0d
Cr-Commit-Position: refs/heads/master@{#394550}

Powered by Google App Engine
This is Rietveld 408576698