Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp

Issue 1987153002: Account for empty stack trace with non-empty async chain in V8Initializer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp
index 90c0ebde9e08a64ee672a3b9a1790785ab8ca766..12ac6517448d8eee7cf0cf67bf17c3b95bd9f01b 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp
@@ -45,7 +45,8 @@ PassRefPtr<ScriptCallStack> ScriptCallStack::create(v8::Isolate* isolate, v8::Lo
V8PerIsolateData* data = V8PerIsolateData::from(isolate);
if (!data->threadDebugger())
return nullptr;
- return adoptRef(new ScriptCallStack(data->threadDebugger()->debugger()->createStackTrace(stackTrace, maxStackSize)));
+ OwnPtr<V8StackTrace> stack = data->threadDebugger()->debugger()->createStackTrace(stackTrace, maxStackSize);
+ return stack ? adoptRef(new ScriptCallStack(std::move(stack))) : nullptr;
}
PassRefPtr<ScriptCallStack> ScriptCallStack::capture(size_t maxStackSize)
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698