Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1987133002: Delete mus surfaces hit testing (Closed)

Created:
4 years, 7 months ago by Fady Samuel
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete mus surfaces hit testing There's a ton of cc plumbing through the window server to support surfaces hittesting. This code exists to support out of process iframes but has been disabled for while. With the mus-ws / mus-gpu split, this code will change radically anyway. To avoid refactoring dead code, I'm deleting it first, and we may reintroduce it in mus-gpu in the future in some new and improved form. BUG=612636, 610937 Committed: https://crrev.com/20e7eba1ee42433ef5e068e58625230ec3d5f1ed Cr-Commit-Position: refs/heads/master@{#394432}

Patch Set 1 #

Patch Set 2 : More code simplification #

Patch Set 3 : Fix unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -134 lines) Patch
M components/mus/surfaces/surfaces_state.h View 1 3 chunks +0 lines, -4 lines 0 comments Download
M components/mus/surfaces/surfaces_state.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M components/mus/ws/display.h View 2 chunks +0 lines, -3 lines 0 comments Download
M components/mus/ws/display.cc View 3 chunks +4 lines, -11 lines 0 comments Download
M components/mus/ws/event_dispatcher.h View 3 chunks +0 lines, -5 lines 0 comments Download
M components/mus/ws/event_dispatcher.cc View 5 chunks +4 lines, -7 lines 0 comments Download
M components/mus/ws/platform_display.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/ws/platform_display_delegate.h View 2 chunks +0 lines, -6 lines 0 comments Download
M components/mus/ws/window_finder.h View 1 chunk +1 line, -3 lines 0 comments Download
M components/mus/ws/window_finder.cc View 6 chunks +4 lines, -69 lines 0 comments Download
M components/mus/ws/window_finder_unittest.cc View 1 2 1 chunk +3 lines, -6 lines 0 comments Download
M components/mus/ws/window_manager_state.h View 3 chunks +1 line, -9 lines 0 comments Download
M components/mus/ws/window_manager_state.cc View 3 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Fady Samuel
4 years, 7 months ago (2016-05-18 01:00:47 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987133002/40001
4 years, 7 months ago (2016-05-18 01:37:51 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-18 03:32:39 UTC) #8
sky
LGTM
4 years, 7 months ago (2016-05-18 15:54:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987133002/40001
4 years, 7 months ago (2016-05-18 15:55:17 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-18 15:59:55 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 16:01:46 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/20e7eba1ee42433ef5e068e58625230ec3d5f1ed
Cr-Commit-Position: refs/heads/master@{#394432}

Powered by Google App Engine
This is Rietveld 408576698