Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 19871003: Simplify how we get the plugin list in the webkit platform support by removing the intermediate met… (Closed)

Created:
7 years, 5 months ago by jam
Modified:
7 years, 5 months ago
Reviewers:
jamesr
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Simplify how we get the plugin list in the webkit platform support by removing the intermediate method. This removes knowledge of WebPluginInfo from webkit/glue, in prepration of moving that struct to content/public/common. BUG=237249 R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212769

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -70 lines) Patch
M content/child/webkitplatformsupport_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/child/webkitplatformsupport_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 4 chunks +33 lines, -10 lines 0 comments Download
M webkit/glue/webkit_glue_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/glue/webkitplatformsupport_impl.h View 4 chunks +2 lines, -10 lines 0 comments Download
M webkit/glue/webkitplatformsupport_impl.cc View 3 chunks +0 lines, -28 lines 0 comments Download
M webkit/support/test_webkit_platform_support.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
7 years, 5 months ago (2013-07-20 00:21:54 UTC) #1
jamesr
lgtm https://codereview.chromium.org/19871003/diff/1/content/renderer/renderer_webkitplatformsupport_impl.cc File content/renderer/renderer_webkitplatformsupport_impl.cc (right): https://codereview.chromium.org/19871003/diff/1/content/renderer/renderer_webkitplatformsupport_impl.cc#newcode931 content/renderer/renderer_webkitplatformsupport_impl.cc:931: UTF8ToUTF16(mime_type.file_extensions[k])); WebString::fromUTF8() here is better since it won't ...
7 years, 5 months ago (2013-07-20 00:26:01 UTC) #2
jam
7 years, 5 months ago (2013-07-20 00:30:39 UTC) #3
https://codereview.chromium.org/19871003/diff/1/content/renderer/renderer_web...
File content/renderer/renderer_webkitplatformsupport_impl.cc (right):

https://codereview.chromium.org/19871003/diff/1/content/renderer/renderer_web...
content/renderer/renderer_webkitplatformsupport_impl.cc:931:
UTF8ToUTF16(mime_type.file_extensions[k]));
On 2013/07/20 00:26:01, jamesr wrote:
> WebString::fromUTF8() here is better since it won't generate a 16 bit string
> unless there are non-latin1 characters in the string.  UTF8ToUTF16 will
inflate
> to a wide string no matter what.  In this instance the size/perf benefits are
> minimal I'm sure, but people may copy-paste the bad pattern into other code.

Done.

Powered by Google App Engine
This is Rietveld 408576698