Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: webkit/glue/webkitplatformsupport_impl.cc

Issue 19871003: Simplify how we get the plugin list in the webkit platform support by removing the intermediate met… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/webkitplatformsupport_impl.h ('k') | webkit/support/test_webkit_platform_support.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webkitplatformsupport_impl.cc
===================================================================
--- webkit/glue/webkitplatformsupport_impl.cc (revision 212672)
+++ webkit/glue/webkitplatformsupport_impl.cc (working copy)
@@ -35,7 +35,6 @@
#include "third_party/WebKit/public/platform/WebData.h"
#include "third_party/WebKit/public/platform/WebDiscardableMemory.h"
#include "third_party/WebKit/public/platform/WebGestureCurve.h"
-#include "third_party/WebKit/public/platform/WebPluginListBuilder.h"
#include "third_party/WebKit/public/platform/WebString.h"
#include "third_party/WebKit/public/platform/WebURL.h"
#include "third_party/WebKit/public/platform/WebVector.h"
@@ -48,7 +47,6 @@
#include "webkit/glue/webkit_glue.h"
#include "webkit/glue/websocketstreamhandle_impl.h"
#include "webkit/glue/weburlloader_impl.h"
-#include "webkit/plugins/webplugininfo.h"
using WebKit::WebAudioBus;
using WebKit::WebCookie;
@@ -387,32 +385,6 @@
return WebURLLoaderImpl::CreateError(unreachableURL, net::ERR_ABORTED);
}
-void WebKitPlatformSupportImpl::getPluginList(bool refresh,
- WebPluginListBuilder* builder) {
- std::vector<webkit::WebPluginInfo> plugins;
- GetPlugins(refresh, &plugins);
-
- for (size_t i = 0; i < plugins.size(); ++i) {
- const webkit::WebPluginInfo& plugin = plugins[i];
-
- builder->addPlugin(
- plugin.name, plugin.desc,
- plugin.path.BaseName().AsUTF16Unsafe());
-
- for (size_t j = 0; j < plugin.mime_types.size(); ++j) {
- const webkit::WebPluginMimeType& mime_type = plugin.mime_types[j];
-
- builder->addMediaTypeToLastPlugin(
- WebString::fromUTF8(mime_type.mime_type), mime_type.description);
-
- for (size_t k = 0; k < mime_type.file_extensions.size(); ++k) {
- builder->addFileExtensionToLastMediaType(
- UTF8ToUTF16(mime_type.file_extensions[k]));
- }
- }
- }
-}
-
void WebKitPlatformSupportImpl::decrementStatsCounter(const char* name) {
base::StatsCounter(name).Decrement();
}
« no previous file with comments | « webkit/glue/webkitplatformsupport_impl.h ('k') | webkit/support/test_webkit_platform_support.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698