Support stacktrace and objecthistogram service commands

runtime/bin/vmservice/service_request.dart

Index: runtime/bin/vmservice/service_request.dart
diff --git a/runtime/bin/vmservice/service_request.dart b/runtime/bin/vmservice/service_request.dart
index 83f26db03a728e372ee76f3a9c51e99ea74bd7d3..fae0a868823556d15f68739d2a0e8a594fc786e9 100644
--- a/runtime/bin/vmservice/service_request.dart
+++ b/runtime/bin/vmservice/service_request.dart
@@ -31,17 +31,18 @@ class ServiceRequest {
     return true;
   }
 
-  String toServiceCallMessage() {
-    return JSON.stringify({
-      'p': pathSegments,
-      'k': parameters.keys.toList(),
-      'v': parameters.values.toList()
-    });
+  List toServiceCallMessage() {
+    var m = [];
+    m.add(pathSegments);
+    m.add(parameters.keys.toList());
+    m.add(parameters.values.toList());

[siva, 2013/08/01 18:16:18]

Might be more readable and more efficient as:

return [pathSegments, parameters.keys.toList(), parameters.values.toList()];

[Cutch, 2013/08/01 22:22:04]

Done.

+    return m;
   }
 
   void setErrorResponse(String error) {
     _response = JSON.stringify({
-        'error': error,
+        'type': 'error',
+        'msg': error,
         'pathSegments': pathSegments,
         'parameters': parameters
     });