Support stacktrace and objecthistogram service commands

runtime/bin/vmservice/service_request.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of vmservice;
 
 class ServiceRequest {
   final List<String> pathSegments = new List<String>();
   final Map<String, String> parameters = new Map<String, String>();
   String _response;
@@ skipping 13 matching lines @@
         continue;
       }
       pathSegments.add(pathSegment);
     }
     uri.queryParameters.forEach((k, v) {
       parameters[k] = v;
     });
     return true;
   }
 
-  String toServiceCallMessage() {
-    return JSON.stringify({
-      'p': pathSegments,
-      'k': parameters.keys.toList(),
-      'v': parameters.values.toList()
-    });
+  List toServiceCallMessage() {
+    var m = [];
+    m.add(pathSegments);
+    m.add(parameters.keys.toList());
+    m.add(parameters.values.toList());

[siva, 2013/08/01 18:16:18]

Might be more readable and more efficient as:

return [pathSegments, parameters.keys.toList(), parameters.values.toList()];

[Cutch, 2013/08/01 22:22:04]

Done.

+    return m;
   }
 
   void setErrorResponse(String error) {
     _response = JSON.stringify({
-        'error': error,
+        'type': 'error',
+        'msg': error,
         'pathSegments': pathSegments,
         'parameters': parameters
     });
   }
 
   void setResponse(String response) {
     _response = response;
   }
 
 }