Web Animations API: Add use counter for Element.animate

Web Animations API: Add use counter for Element.animate

Adds one Feature to UseCounter for each version of Element.animate().

More Features will need to be added as Element.animate() expands.

BUG=352490, 352491
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169323

[rjwright, 2014-03-13 07:16:31]

ptal

Should we add Features to UseCounter now for anticipated  versions of
Element.animate?

[Eric Willigers, 2014-03-14 01:47:24]

lgtm

[Timothy Loh, 2014-03-14 03:05:04]

On 2014/03/13 07:16:31, rjwright wrote:
> ptal
> 
> Should we add Features to UseCounter now for anticipated  versions of
> Element.animate?

Do we have a tracking bug for this? It isn't clear what subset of Web Animations
we're going to want to track and tracking each combination of the IDL union
types doesn't seem very useful.

[rjwright1, 2014-03-14 03:09:09]

It won't be this messy to track every version because we can put the count
call in the IDL. It just means adding a lot of new features in UseCounter.h.

We should have a bug and a plan though. I was just going to jump in and do
the obvious ones and then figure it out when it becomes unclear. Maybe we
should write it up first.


On Fri, Mar 14, 2014 at 2:05 PM, <timloh@chromium.org> wrote:

> On 2014/03/13 07:16:31, rjwright wrote:
>
>> ptal
>>
>
>  Should we add Features to UseCounter now for anticipated  versions of
>> Element.animate?
>>
>
> Do we have a tracking bug for this? It isn't clear what subset of Web
> Animations
> we're going to want to track and tracking each combination of the IDL union
> types doesn't seem very useful.
>
> https://codereview.chromium.org/198693002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[shans, 2014-03-14 03:09:30]

On 2014/03/14 03:05:04, Timothy Loh wrote:
> On 2014/03/13 07:16:31, rjwright wrote:
> > ptal
> > 
> > Should we add Features to UseCounter now for anticipated  versions of
> > Element.animate?
> 
> Do we have a tracking bug for this? It isn't clear what subset of Web
Animations
> we're going to want to track and tracking each combination of the IDL union
> types doesn't seem very useful.

Au contraire, it will provide potentially very valuable data about how the API
is used.

[rjwright1, 2014-03-14 03:13:01]

Yeah I think it will be very interesting (and maybe even useful :P )

I still need to know whether to add them all to UseCounter.h now or later
though. I think later, but it will mean they are mixed in with other
entries (kinda depends on if we can reserve them in a block and just change
the name of them once we actually start using them, if need be).


On Fri, Mar 14, 2014 at 2:09 PM, <shans@chromium.org> wrote:

> On 2014/03/14 03:05:04, Timothy Loh wrote:
>
>> On 2014/03/13 07:16:31, rjwright wrote:
>> > ptal
>> >
>> > Should we add Features to UseCounter now for anticipated  versions of
>> > Element.animate?
>>
>
>  Do we have a tracking bug for this? It isn't clear what subset of Web
>>
> Animations
>
>> we're going to want to track and tracking each combination of the IDL
>> union
>> types doesn't seem very useful.
>>
>
> Au contraire, it will provide potentially very valuable data about how the
> API
> is used.
>
> https://codereview.chromium.org/198693002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[rjwright, 2014-03-14 04:04:20]

ptal

[dstockwell, 2014-03-14 06:25:28]

lgtm

[commit-bot: I haz the power, 2014-03-14 06:25:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rjwright@chromium.org/198693002/20001

[commit-bot: I haz the power, 2014-03-14 06:26:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-14 06:26:11]

Failed to apply patch for Source/core/frame/UseCounter.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/UseCounter.h
  Hunk #1 FAILED at 305.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/UseCounter.h.rej

Patch:       Source/core/frame/UseCounter.h
Index: Source/core/frame/UseCounter.h
diff --git a/Source/core/frame/UseCounter.h b/Source/core/frame/UseCounter.h
index
bae636289a04c8c7d0d8e0061f5f7e93ca14ca56..5a6b9e4bed26787a85ee99bce50cb6b5ebb2c2f1
100644
--- a/Source/core/frame/UseCounter.h
+++ b/Source/core/frame/UseCounter.h
@@ -305,6 +305,9 @@ public:
         DocumentReleaseEvents = 288,
         WindowCaptureEvents = 289,
         WindowReleaseEvents = 290,
+        ElementAnimateKeyframeListEffectObjectTiming = 291,
+        ElementAnimateKeyframeListEffectDoubleTiming = 292,
+        ElementAnimateKeyframeListEffectNoTiming = 293,
         // Add new features immediately above this line. Don't change assigned
         // numbers of any item, and don't reuse removed slots.
         NumberOfFeatures, // This enum value must be last.

[rjwright, 2014-03-17 01:47:08]

The CQ bit was checked by rjwright@chromium.org

[commit-bot: I haz the power, 2014-03-17 01:47:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rjwright@chromium.org/198693002/40001

[rjwright, 2014-03-17 01:52:57]

The CQ bit was checked by rjwright@chromium.org

[commit-bot: I haz the power, 2014-03-17 01:53:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rjwright@chromium.org/198693002/60001

[commit-bot: I haz the power, 2014-03-17 02:46:38]

Change committed as 169323

[Mike Lawther (Google), 2014-03-20 05:28:25]

You'll also need to update tools/metrics/histograms/histograms.xml in the
chromium repo. This is how the dashboards map a name to a histogram value. See
eg https://codereview.chromium.org/20203003.