Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 20203003: Update histograms.xml for recent Blink UseCounter addition. (Closed)

Created:
7 years, 5 months ago by tkent
Modified:
7 years, 5 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, Yuta Kitamura, pdr., Raphael Kubo da Costa (rakuco), dominicc (has gone to gerrit)
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Moved SVGAnimationElement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M tools/metrics/histograms/histograms.xml View 1 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
tkent
7 years, 5 months ago (2013-07-25 08:13:58 UTC) #1
Yuta Kitamura
Thanks for taking care of this. I actually was not aware that the enum needs ...
7 years, 5 months ago (2013-07-25 08:26:07 UTC) #2
tkent
> nit: histgrams.xml -> histograms.xml in change description. Oops! Fixed.
7 years, 5 months ago (2013-07-25 08:35:12 UTC) #3
Ilya Sherman
https://codereview.chromium.org/20203003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/20203003/diff/1/tools/metrics/histograms/histograms.xml#newcode16895 tools/metrics/histograms/histograms.xml:16895: <int value="22" label="SVGAnimationElement"/> Hmm, why did this enum value ...
7 years, 5 months ago (2013-07-26 01:20:29 UTC) #4
tkent
https://codereview.chromium.org/20203003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/20203003/diff/1/tools/metrics/histograms/histograms.xml#newcode16895 tools/metrics/histograms/histograms.xml:16895: <int value="22" label="SVGAnimationElement"/> On 2013/07/26 01:20:30, Ilya Sherman wrote: ...
7 years, 5 months ago (2013-07-26 01:38:41 UTC) #5
tkent
Updated the patch. PTAL.
7 years, 5 months ago (2013-07-26 03:08:23 UTC) #6
Ilya Sherman
LGTM, thanks.
7 years, 5 months ago (2013-07-26 04:28:19 UTC) #7
tkent
7 years, 5 months ago (2013-07-26 05:10:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r213765 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698