Move TypeParameterizedElementForLink and TypeParameterElementForLink to impl.

pkg/analyzer/test/src/summary/resynthesize_test.dart

Index: pkg/analyzer/test/src/summary/resynthesize_test.dart
diff --git a/pkg/analyzer/test/src/summary/resynthesize_test.dart b/pkg/analyzer/test/src/summary/resynthesize_test.dart
index e4f296e1d7d882c1cfe7ea0d397abe06c4c66cc4..23ff7e59f71e459073215f10a24dde04946c2843 100644
--- a/pkg/analyzer/test/src/summary/resynthesize_test.dart
+++ b/pkg/analyzer/test/src/summary/resynthesize_test.dart
@@ -674,7 +674,10 @@ abstract class AbstractResynthesizeTest extends AbstractSingleUnitTest {
     expect(resynthesized.documentationComment, original.documentationComment,
         reason: desc);
     expect(resynthesized.docRange, original.docRange, reason: desc);
-    compareMetadata(resynthesized.metadata, original.metadata, desc);
+    // TODO(scheglov) MLI restore testing annotations for type parameters

[Paul Berry, 2016/05/17 19:28:02]

Another unclear usage of "MLI"

[scheglov, 2016/05/17 19:42:21]

Done.

+    if (original is TypeParameterElement) {} else {

[Paul Berry, 2016/05/17 19:28:02]

Nit: use "is!" to avoid the empty if-clause.

How long do you anticipate needing to keep this code disabled?  If it's just for
a day or two, then I'm not concerned.  But if it stays disabled longer, I worry
that this will become a gap in our testing, and I especially want to avoid that
because I'm guessing that the resynthesis code is going to be touched a lot in
your current arc of work, and it would be good to keep our test coverage high
while that's happening.

[scheglov, 2016/05/17 19:42:21]

Yeah, I don't like turning off tests too.
I will try to restore it ASAP.
Hopefully this feature (annotations of type parameters) is not used often.

[Brian Wilkerson, 2016/05/17 19:43:57]

If they are not already doing so, the flutter team plans to do this a lot (the
@required annotation).

+      compareMetadata(resynthesized.metadata, original.metadata, desc);
+    }
 
     // Validate modifiers.
     for (Modifier modifier in Modifier.persistedValues) {