Move TypeParameterizedElementForLink and TypeParameterElementForLink to impl.

pkg/analyzer/test/src/summary/resynthesize_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.src.serialization.elements_test;
 
 import 'dart:convert';
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/constant/value.dart';
@@ skipping 656 matching lines @@
     }
     expect(resynthesized.kind, original.kind);
     expect(resynthesized.location, original.location, reason: desc);
     expect(resynthesized.name, original.name);
     expect(resynthesized.nameOffset, original.nameOffset, reason: desc);
     expect(rImpl.codeOffset, oImpl.codeOffset, reason: desc);
     expect(rImpl.codeLength, oImpl.codeLength, reason: desc);
     expect(resynthesized.documentationComment, original.documentationComment,
         reason: desc);
     expect(resynthesized.docRange, original.docRange, reason: desc);
-    compareMetadata(resynthesized.metadata, original.metadata, desc);
+    // TODO(scheglov) MLI restore testing annotations for type parameters

[Paul Berry, 2016/05/17 19:28:02]

Another unclear usage of "MLI"

[scheglov, 2016/05/17 19:42:21]

Done.

+    if (original is TypeParameterElement) {} else {

[Paul Berry, 2016/05/17 19:28:02]

Nit: use "is!" to avoid the empty if-clause.

How long do you anticipate needing to keep this code disabled?  If it's just for
a day or two, then I'm not concerned.  But if it stays disabled longer, I worry
that this will become a gap in our testing, and I especially want to avoid that
because I'm guessing that the resynthesis code is going to be touched a lot in
your current arc of work, and it would be good to keep our test coverage high
while that's happening.

[scheglov, 2016/05/17 19:42:21]

Yeah, I don't like turning off tests too.
I will try to restore it ASAP.
Hopefully this feature (annotations of type parameters) is not used often.

[Brian Wilkerson, 2016/05/17 19:43:57]

If they are not already doing so, the flutter team plans to do this a lot (the
@required annotation).

+      compareMetadata(resynthesized.metadata, original.metadata, desc);
+    }
 
     // Validate modifiers.
     for (Modifier modifier in Modifier.persistedValues) {
       bool got = _hasModifier(resynthesized, modifier);
       bool want = _hasModifier(original, modifier);
       expect(got, want,
           reason: 'Mismatch in $desc.$modifier: got $got, want $want');
     }
     for (Modifier modifier in Modifier.transientValues) {
       bool got = rImpl.hasModifier(modifier);
@@ skipping 3834 matching lines @@
       fail('Unexpectedly tried to get unlinked summary for $uri');
     }
     return serializedUnit;
   }
 
   @override
   bool hasLibrarySummary(String uri) {
     return true;
   }
 }