third_party/WebKit/Source/core/loader/EmptyClients.h - Issue 1986783002: Text selected with double-tap should not cause vibration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/EmptyClients.h

Issue 1986783002: Text selected with double-tap should not cause vibration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make sure we are in Android before saying context menu was not handled Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java ('K') | « content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java ('k') | third_party/WebKit/Source/core/page/ContextMenuClient.h » ('j') | third_party/WebKit/Source/core/page/ContextMenuController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/EmptyClients.h

diff --git a/third_party/WebKit/Source/core/loader/EmptyClients.h b/third_party/WebKit/Source/core/loader/EmptyClients.h

index c4084d3f33d6a014fb72a92c03cdf46c48b53bcc..0f90007f4f4d4adfcbb6dc4fae3d3eaffeaf275e 100644

--- a/third_party/WebKit/Source/core/loader/EmptyClients.h

+++ b/third_party/WebKit/Source/core/loader/EmptyClients.h

@@ -324,7 +324,7 @@ class EmptyContextMenuClient final : public ContextMenuClient {

public:

EmptyContextMenuClient() {}

~EmptyContextMenuClient() override {}

- void showContextMenu(const ContextMenu*) override {}

+ bool showContextMenu(const ContextMenu*) override { return false; }

void clearContextMenu() override {}

};