Text selected with double-tap should not cause vibration

third_party/WebKit/Source/core/page/ContextMenuController.cpp

Index: third_party/WebKit/Source/core/page/ContextMenuController.cpp
diff --git a/third_party/WebKit/Source/core/page/ContextMenuController.cpp b/third_party/WebKit/Source/core/page/ContextMenuController.cpp
index 9f367910474810e788cfd9256eccf9d8b759566f..8eff8007782e535497885d194587917f2eacf261 100644
--- a/third_party/WebKit/Source/core/page/ContextMenuController.cpp
+++ b/third_party/WebKit/Source/core/page/ContextMenuController.cpp
@@ -173,8 +173,7 @@ PassOwnPtr<ContextMenu> ContextMenuController::createContextMenu(LocalFrame* fra
 
 void ContextMenuController::showContextMenu(Event* event)

[aelias_OOO_until_Jul13, 2016/05/18 01:22:32]

I'd suggest adding a unit test for the new logic in
ContextMenuControllerTest.cpp.  I suggest checking whether showContextMenu()
executed or not by looking for its side effects.  (I suggest also looking at
WebViewTest.cpp and WebFrameTest.cpp for inspiration on how Blink unit tests can
be written.)

[amaralp, 2016/05/18 22:16:18]

Acknowledged.

 {
-    m_client->showContextMenu(m_contextMenu.get());
-    if (event)
+    if (m_client->showContextMenu(m_contextMenu.get()) && event)
         event->setDefaultHandled();
 }