components/offline_pages/offline_page_model.cc - Issue 1986673002: [Offline Pages] Updated clearing logic in storage manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_model.cc

Issue 1986673002: [Offline Pages] Updated clearing logic in storage manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refactored to short circuit earlier if no need to clear. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/offline_pages/archive_manager.cc ('K') | « components/offline_pages/archive_manager.cc ('k') | components/offline_pages/offline_page_storage_manager.h » ('j') | components/offline_pages/offline_page_storage_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/offline_page_model.cc

diff --git a/components/offline_pages/offline_page_model.cc b/components/offline_pages/offline_page_model.cc

index f1540dab1fc29eee43f5227d5dbb9d20a0d7cfed..701c69063e8569d6e0771975ac9e269283e6e604 100644

--- a/components/offline_pages/offline_page_model.cc

+++ b/components/offline_pages/offline_page_model.cc

@@ -620,8 +620,8 @@ void OfflinePageModel::OnLoadDone(

base::TimeTicks::Now() - start_time);

// Create Storage Manager.

- storage_manager_.reset(

- new OfflinePageStorageManager(this, GetPolicyController()));

+ storage_manager_.reset(new OfflinePageStorageManager(

+ this, GetPolicyController(), archive_manager_.get()));

// Run all the delayed tasks.

for (const auto& delayed_task : delayed_tasks_)