components/offline_pages/archive_manager.cc - Issue 1986673002: [Offline Pages] Updated clearing logic in storage manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/archive_manager.cc

Issue 1986673002: [Offline Pages] Updated clearing logic in storage manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refactored to short circuit earlier if no need to clear. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/archive_manager.h ('k') | components/offline_pages/offline_page_model.cc » ('j') | components/offline_pages/offline_page_storage_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/archive_manager.cc

diff --git a/components/offline_pages/archive_manager.cc b/components/offline_pages/archive_manager.cc

index 9dfeabbe0b0c82460a888db52c37535e5edea693..98af189524cd63fb5c36f572d2dbf22dcb98a1f0 100644

--- a/components/offline_pages/archive_manager.cc

+++ b/components/offline_pages/archive_manager.cc

@@ -118,4 +118,7 @@ void ArchiveManager::GetStorageStats(

base::ThreadTaskRunnerHandle::Get(), callback));

}

+// protected.

+ArchiveManager::ArchiveManager() {}

fgorski 2016/05/19 04:14:22 constructors go above methods.

romax 2016/05/19 18:34:41 Done.

} // namespace offline_pages