components/offline_pages/archive_manager.cc - Issue 1986673002: [Offline Pages] Updated clearing logic in storage manager.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/offline_pages/archive_manager.cc

Issue 1986673002: [Offline Pages] Updated clearing logic in storage manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refactored to short circuit earlier if no need to clear. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/offline_pages/archive_manager.h ('k') | components/offline_pages/offline_page_model.cc » ('j') | components/offline_pages/offline_page_storage_manager.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/bind.h"	5 #include "base/bind.h"

6 #include "base/callback.h"	6 #include "base/callback.h"

7 #include "base/files/file_enumerator.h"	7 #include "base/files/file_enumerator.h"

8 #include "base/files/file_util.h"	8 #include "base/files/file_util.h"

9 #include "base/location.h"	9 #include "base/location.h"

10 #include "base/logging.h"	10 #include "base/logging.h"

(...skipping 100 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
111 base::ThreadTaskRunnerHandle::Get(), callback));	111 base::ThreadTaskRunnerHandle::Get(), callback));

112 }	112 }

113	113

114 void ArchiveManager::GetStorageStats(	114 void ArchiveManager::GetStorageStats(

115 const StorageStatsCallback& callback) const {	115 const StorageStatsCallback& callback) const {

116 task_runner_->PostTask(	116 task_runner_->PostTask(

117 FROM_HERE, base::Bind(GetStorageStatsImpl, archives_dir_,	117 FROM_HERE, base::Bind(GetStorageStatsImpl, archives_dir_,

118 base::ThreadTaskRunnerHandle::Get(), callback));	118 base::ThreadTaskRunnerHandle::Get(), callback));

119 }	119 }

120	120

	121 // protected.

	122 ArchiveManager::ArchiveManager() {}
	fgorski 2016/05/19 04:14:22 constructors go above methods. constructors go above methods. romax 2016/05/19 18:34:41 Done. Show quoted text On 2016/05/19 04:14:22, fgorski wrote: > constructors go above methods. Done.
	123

121 } // namespace offline_pages	124 } // namespace offline_pages

OLD	NEW