Enable AltSvc pooling by default.

Enable AltSvc pooling by default.

* Change enable_alternative_service_with_different_host default value to true in
  production.
* Change enable_alternative_service_with_different_host default value to true in
  tests.
* Remove kEnableAlternativeServices command line switch.
* Change QUIC field trial parameter "enable_alternative_service_with_different_host"
  behavior from enabling if true to disabling if value is false.

BUG=392575
Committed: https://crrev.com/58f0aa68fb0a15b0af56e7cfdf833ac3108fa00e
Cr-Commit-Position: refs/heads/master@{#396508}

[Bence, 2016-05-17 14:19:22]

bnc@chromium.org changed reviewers:
+ bengr@chromium.org, rch@chromium.org

[Bence, 2016-05-17 14:19:23]

Ryan: PTAL at chrome/, ios/, and net/.
Ben: PTAL at components/.

Thank you both.

[bengr, 2016-05-17 17:33:22]

components/* lgtm

[Ryan Hamilton, 2016-05-20 21:44:42]

https://codereview.chromium.org/1986633002/diff/20001/net/http/http_network_s...
File net/http/http_network_session.cc (right):

https://codereview.chromium.org/1986633002/diff/20001/net/http/http_network_s...
net/http/http_network_session.cc:100:
enable_alternative_service_with_different_host(true),
If this defaults to true and is never set to false, can we just remove it?

[Bence, 2016-05-21 16:02:34]

On 2016/05/20 21:44:42, Ryan Hamilton wrote:
>
https://codereview.chromium.org/1986633002/diff/20001/net/http/http_network_s...
> File net/http/http_network_session.cc (right):
> 
>
https://codereview.chromium.org/1986633002/diff/20001/net/http/http_network_s...
> net/http/http_network_session.cc:100:
> enable_alternative_service_with_different_host(true),
> If this defaults to true and is never set to false, can we just remove it?

Yes.  I would prefer to do that in a follow-up CL, since it affects twice as
many files, and in my mind it is a distinct step.

[Bence, 2016-05-27 13:56:28]

Description was changed from

==========
Enable AltSvc pooling.

* Change enable_alternative_service_with_different_host default value to true in
  production.
* Change enable_alternative_service_with_different_host default value to true in
  tests.
* Remove QUIC field trial parameter that used to enable this flag.

BUG=392575
==========

to

==========
Enable AltSvc pooling by default.

* Change enable_alternative_service_with_different_host default value to true in
  production.
* Change enable_alternative_service_with_different_host default value to true in
  tests.
* Remove kEnableAlternativeServices command line switch.
* Change QUIC field trial parameter
"enable_alternative_service_with_different_host"
  behavior from enabling if true to disabling if value is false.

BUG=392575
==========

[Bence, 2016-05-27 16:01:18]

Ryan: PTAL.  There's no reason to fret about what happens in the
ParseAltSvc:Disabled experiment group, because that will be soon removed at
https://crrev.com/2011983002.

https://codereview.chromium.org/1986633002/diff/20001/net/http/http_network_s...
File net/http/http_network_session.cc (right):

https://codereview.chromium.org/1986633002/diff/20001/net/http/http_network_s...
net/http/http_network_session.cc:100:
enable_alternative_service_with_different_host(true),
On 2016/05/20 21:44:42, Ryan Hamilton wrote:
> If this defaults to true and is never set to false, can we just remove it?

Moot since we are keeping the flag as a kill switch.

[Ryan Hamilton, 2016-05-27 17:41:22]

lgtm

Woo hoo!

[Bence, 2016-05-27 17:57:03]

The CQ bit was checked by bnc@chromium.org

[Bence, 2016-05-27 17:57:04]

The patchset sent to the CQ was uploaded after l-g-t-m from bengr@chromium.org
Link to the patchset: https://codereview.chromium.org/1986633002/#ps60001
(title: "Update trial logic and tests.")

[commit-bot: I haz the power, 2016-05-27 17:57:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1986633002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1986633002/60001

[commit-bot: I haz the power, 2016-05-27 18:02:39]

Description was changed from

==========
Enable AltSvc pooling by default.

* Change enable_alternative_service_with_different_host default value to true in
  production.
* Change enable_alternative_service_with_different_host default value to true in
  tests.
* Remove kEnableAlternativeServices command line switch.
* Change QUIC field trial parameter
"enable_alternative_service_with_different_host"
  behavior from enabling if true to disabling if value is false.

BUG=392575
==========

to

==========
Enable AltSvc pooling by default.

* Change enable_alternative_service_with_different_host default value to true in
  production.
* Change enable_alternative_service_with_different_host default value to true in
  tests.
* Remove kEnableAlternativeServices command line switch.
* Change QUIC field trial parameter
"enable_alternative_service_with_different_host"
  behavior from enabling if true to disabling if value is false.

BUG=392575
==========

[commit-bot: I haz the power, 2016-05-27 18:02:41]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-27 18:04:33]

Description was changed from

==========
Enable AltSvc pooling by default.

* Change enable_alternative_service_with_different_host default value to true in
  production.
* Change enable_alternative_service_with_different_host default value to true in
  tests.
* Remove kEnableAlternativeServices command line switch.
* Change QUIC field trial parameter
"enable_alternative_service_with_different_host"
  behavior from enabling if true to disabling if value is false.

BUG=392575
==========

to

==========
Enable AltSvc pooling by default.

* Change enable_alternative_service_with_different_host default value to true in
  production.
* Change enable_alternative_service_with_different_host default value to true in
  tests.
* Remove kEnableAlternativeServices command line switch.
* Change QUIC field trial parameter
"enable_alternative_service_with_different_host"
  behavior from enabling if true to disabling if value is false.

BUG=392575

Committed: https://crrev.com/58f0aa68fb0a15b0af56e7cfdf833ac3108fa00e
Cr-Commit-Position: refs/heads/master@{#396508}
==========

[commit-bot: I haz the power, 2016-05-27 18:04:34]

Patchset 4 (id:??) landed as
https://crrev.com/58f0aa68fb0a15b0af56e7cfdf833ac3108fa00e
Cr-Commit-Position: refs/heads/master@{#396508}