components/network_session_configurator/network_session_configurator_unittest.cc - Issue 1986633002: Enable AltSvc pooling by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/network_session_configurator/network_session_configurator_unittest.cc

Issue 1986633002: Enable AltSvc pooling by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update trial logic and tests. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/network_session_configurator/network_session_configurator.cc ('k') | components/network_session_configurator/switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/network_session_configurator/network_session_configurator_unittest.cc

diff --git a/components/network_session_configurator/network_session_configurator_unittest.cc b/components/network_session_configurator/network_session_configurator_unittest.cc

index bcc14ee319f99d81199f5b3d7da025fd0904ade4..4156c50dd9369d22a497f198cf93ff0827822b3f 100644

--- a/components/network_session_configurator/network_session_configurator_unittest.cc

+++ b/components/network_session_configurator/network_session_configurator_unittest.cc

@@ -58,7 +58,7 @@ TEST_F(NetworkSessionConfiguratorTest, Defaults) {

EXPECT_TRUE(params_.enable_http2);

EXPECT_FALSE(params_.enable_tcp_fast_open_for_ssl);

EXPECT_TRUE(params_.parse_alternative_services);

- EXPECT_FALSE(params_.enable_alternative_service_with_different_host);

+ EXPECT_TRUE(params_.enable_alternative_service_with_different_host);

EXPECT_FALSE(params_.enable_npn);

EXPECT_TRUE(params_.enable_priority_dependencies);

EXPECT_FALSE(params_.enable_quic);

@@ -91,7 +91,7 @@ TEST_F(NetworkSessionConfiguratorTest, AltSvcFieldTrialEnabled) {

ParseFieldTrials();

EXPECT_TRUE(params_.parse_alternative_services);

- EXPECT_FALSE(params_.enable_alternative_service_with_different_host);

+ EXPECT_TRUE(params_.enable_alternative_service_with_different_host);

}

TEST_F(NetworkSessionConfiguratorTest, AltSvcFieldTrialDisabled) {

@@ -100,7 +100,7 @@ TEST_F(NetworkSessionConfiguratorTest, AltSvcFieldTrialDisabled) {

ParseFieldTrials();

EXPECT_FALSE(params_.parse_alternative_services);

- EXPECT_FALSE(params_.enable_alternative_service_with_different_host);

+ EXPECT_TRUE(params_.enable_alternative_service_with_different_host);

}

TEST_F(NetworkSessionConfiguratorTest, SpdyFieldTrialHoldbackEnabled) {

@@ -215,7 +215,7 @@ TEST_F(NetworkSessionConfiguratorTest, EnableQuicFromFieldTrialGroup) {

EXPECT_FALSE(params_.quic_disable_disk_cache);

EXPECT_FALSE(params_.quic_prefer_aes);

EXPECT_TRUE(params_.parse_alternative_services);

- EXPECT_FALSE(params_.enable_alternative_service_with_different_host);

+ EXPECT_TRUE(params_.enable_alternative_service_with_different_host);

EXPECT_EQ(0, params_.quic_max_number_of_lossy_connections);

EXPECT_EQ(1.0f, params_.quic_packet_loss_threshold);

EXPECT_TRUE(params_.quic_delay_tcp_race);