Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1986533002: Fix the code that causes warnings (Closed)

Created:
4 years, 7 months ago by Wei Li
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix the code that causes warnings These are the left or newly added code which causes compilation warnings of "signed and unsigned comparison". Need to fix them before I re-enable the warning flag. BUG=pdfium:29 Committed: https://pdfium.googlesource.com/pdfium/+/3cc01f2ba255f4b7584668ee2b8e5ed97792c26d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -38 lines) Patch
M core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fxcrt/fx_basic_wstring.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/fxcrt/fx_basic_wstring_unittest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M core/fxge/win32/fx_win32_gdipext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfview_embeddertest.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M xfa/fgas/localization/fgas_locale.cpp View 4 chunks +12 lines, -12 lines 0 comments Download
M xfa/fgas/xml/fgas_sax.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/datamatrix/BC_ErrorCorrection.cpp View 1 chunk +6 lines, -8 lines 0 comments Download
M xfa/fxbarcode/datamatrix/BC_HighLevelEncoder.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Wei Li
pls review, thanks
4 years, 7 months ago (2016-05-16 19:44:38 UTC) #2
dsinclair
lgtm
4 years, 7 months ago (2016-05-16 19:49:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986533002/1
4 years, 7 months ago (2016-05-16 19:49:38 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 20:53:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/3cc01f2ba255f4b7584668ee2b8e5ed97792...

Powered by Google App Engine
This is Rietveld 408576698