core/fxcrt/fx_basic_wstring.cpp - Issue 1986533002: Fix the code that causes warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/fx_basic_wstring.cpp

Issue 1986533002: Fix the code that causes warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcrt/fx_basic_wstring.cpp

diff --git a/core/fxcrt/fx_basic_wstring.cpp b/core/fxcrt/fx_basic_wstring.cpp

index 241c3a6985eda6169e2952c01787db2685af6552..ba86823fe23fd8ae7472f4b0aa1dc618fc9b1b6d 100644

--- a/core/fxcrt/fx_basic_wstring.cpp

+++ b/core/fxcrt/fx_basic_wstring.cpp

@@ -894,7 +894,8 @@ void CFX_WideString::TrimLeft(const CFX_WideStringC& pTargets) {

FX_STRSIZE pos = 0;

while (pos < len) {

FX_STRSIZE i = 0;

- while (i < pTargets.GetLength() && pTargets[i] != m_pData->m_String[pos]) {

+ while (i < pTargets.GetLength() &&

+ pTargets.CharAt(i) != m_pData->m_String[pos]) {

i++;

}

if (i == pTargets.GetLength()) {

« no previous file with comments | « core/fpdfapi/fpdf_parser/cpdf_document.cpp ('k') | core/fxcrt/fx_basic_wstring_unittest.cpp » ('j') | no next file with comments »