Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Unified Diff: xfa/fxfa/include/fxfa.h

Issue 1986503002: XFA_WIDGETSTATUS, LAYOUTSTATUS and WIDGETFILTER cleanup. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/fxfa/app/xfa_rendercontext.cpp ('k') | xfa/fxfa/parser/xfa_doclayout.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fxfa/include/fxfa.h
diff --git a/xfa/fxfa/include/fxfa.h b/xfa/fxfa/include/fxfa.h
index a7d1a282ba37d02159af5075a2acccb3d9063c37..4e6ac4caaa241979a4f5a542927833e620e7ff8d 100644
--- a/xfa/fxfa/include/fxfa.h
+++ b/xfa/fxfa/include/fxfa.h
@@ -185,12 +185,19 @@ class IXFA_WidgetIterator;
#define XFA_WIDGETFILTER_Field 0x0100
#define XFA_WIDGETFILTER_AllType 0x0F00
-#define XFA_WIDGETSTATUS_Visible 0x00000001
-#define XFA_WIDGETSTATUS_Invisible 0x00000002
-#define XFA_WIDGETSTATUS_Hidden 0x00000004
-#define XFA_WIDGETSTATUS_Viewable 0x00000010
-#define XFA_WIDGETSTATUS_Printable 0x00000020
-#define XFA_WIDGETSTATUS_Focused 0x00000100
+enum XFA_WidgetStatus {
Tom Sepez 2016/05/16 18:36:57 Any reason not an enum class?
dsinclair 2016/05/16 18:39:27 We | and & the values together which, I believe, y
+ XFA_WidgetStatus_None = 1 << 0,
+ XFA_WidgetStatus_Access = 1 << 1,
+ XFA_WidgetStatus_ButtonDown = 1 << 2,
+ XFA_WidgetStatus_Disabled = 1 << 3,
+ XFA_WidgetStatus_Focused = 1 << 4,
+ XFA_WidgetStatus_Highlight = 1 << 5,
+ XFA_WidgetStatus_Printable = 1 << 6,
+ XFA_WidgetStatus_RectCached = 1 << 7,
+ XFA_WidgetStatus_TextEditValueChanged = 1 < 8,
+ XFA_WidgetStatus_Viewable = 1 << 9,
+ XFA_WidgetStatus_Visible = 1 << 10
+};
enum XFA_EVENTTYPE {
XFA_EVENT_Click,
« no previous file with comments | « xfa/fxfa/app/xfa_rendercontext.cpp ('k') | xfa/fxfa/parser/xfa_doclayout.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698