XFA_WIDGETSTATUS, LAYOUTSTATUS and WIDGETFILTER cleanup.

xfa/fxfa/include/fxfa.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef XFA_FXFA_INCLUDE_FXFA_H_
 #define XFA_FXFA_INCLUDE_FXFA_H_
 
 #include <vector>
@@ skipping 167 matching lines @@
 #define XFA_RENDERSTATUS_Failed -1
 
 #define XFA_TRAVERSEWAY_Tranvalse 0x0001
 #define XFA_TRAVERSEWAY_Form 0x0002
 #define XFA_WIDGETFILTER_Visible 0x0001
 #define XFA_WIDGETFILTER_Viewable 0x0010
 #define XFA_WIDGETFILTER_Printable 0x0020
 #define XFA_WIDGETFILTER_Field 0x0100
 #define XFA_WIDGETFILTER_AllType 0x0F00
 
-#define XFA_WIDGETSTATUS_Visible 0x00000001
-#define XFA_WIDGETSTATUS_Invisible 0x00000002
-#define XFA_WIDGETSTATUS_Hidden 0x00000004
-#define XFA_WIDGETSTATUS_Viewable 0x00000010
-#define XFA_WIDGETSTATUS_Printable 0x00000020
-#define XFA_WIDGETSTATUS_Focused 0x00000100
+enum XFA_WidgetStatus {

[Tom Sepez, 2016/05/16 18:36:57]

Any reason not an enum class?

[dsinclair, 2016/05/16 18:39:27]

We | and & the values together which, I believe, you can't do with an enum
class.

+  XFA_WidgetStatus_None = 1 << 0,
+  XFA_WidgetStatus_Access = 1 << 1,
+  XFA_WidgetStatus_ButtonDown = 1 << 2,
+  XFA_WidgetStatus_Disabled = 1 << 3,
+  XFA_WidgetStatus_Focused = 1 << 4,
+  XFA_WidgetStatus_Highlight = 1 << 5,
+  XFA_WidgetStatus_Printable = 1 << 6,
+  XFA_WidgetStatus_RectCached = 1 << 7,
+  XFA_WidgetStatus_TextEditValueChanged = 1 < 8,
+  XFA_WidgetStatus_Viewable = 1 << 9,
+  XFA_WidgetStatus_Visible = 1 << 10
+};
 
 enum XFA_EVENTTYPE {
   XFA_EVENT_Click,
   XFA_EVENT_Change,
   XFA_EVENT_DocClose,
   XFA_EVENT_DocReady,
   XFA_EVENT_Enter,
   XFA_EVENT_Exit,
   XFA_EVENT_Full,
   XFA_EVENT_IndexChange,
@@ skipping 339 matching lines @@
   virtual CXFA_FFWidget* MoveToNext() = 0;
   virtual CXFA_FFWidget* MoveToPrevious() = 0;
   virtual CXFA_FFWidget* GetCurrentWidget() = 0;
   virtual FX_BOOL SetCurrentWidget(CXFA_FFWidget* hWidget) = 0;
 
  protected:
   virtual ~IXFA_WidgetIterator() {}
 };
 
 #endif  // XFA_FXFA_INCLUDE_FXFA_H_