XFA_WIDGETSTATUS, LAYOUTSTATUS and WIDGETFILTER cleanup.

XFA_WIDGETSTATUS cleanup.

This CL moves all of the XFA_WIDGETSTATUS values into a single enum instead
of multiple defines. The values are also normalized.

The name was updated to be XFA_WidgetStatus.

The XFA_WIDGETFILTER and XFA_LAYOUTSTATUS defines had to
match up to XFA_WIDGETSTATUS. This Cl replaces those so
we just have a single enum to work with.

Committed: https://pdfium.googlesource.com/pdfium/+/935d8d5dcbf1da2b3198675428cbf7ca0406788f

[dsinclair, 2016-05-16 18:32:24]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-05-16 18:32:25]

PTAL.

[Tom Sepez, 2016-05-16 18:36:58]

https://codereview.chromium.org/1986503002/diff/1/xfa/fxfa/include/fxfa.h
File xfa/fxfa/include/fxfa.h (right):

https://codereview.chromium.org/1986503002/diff/1/xfa/fxfa/include/fxfa.h#new...
xfa/fxfa/include/fxfa.h:188: enum XFA_WidgetStatus {
Any reason not an enum class?

[dsinclair, 2016-05-16 18:39:27]

https://codereview.chromium.org/1986503002/diff/1/xfa/fxfa/include/fxfa.h
File xfa/fxfa/include/fxfa.h (right):

https://codereview.chromium.org/1986503002/diff/1/xfa/fxfa/include/fxfa.h#new...
xfa/fxfa/include/fxfa.h:188: enum XFA_WidgetStatus {
On 2016/05/16 18:36:57, Tom Sepez wrote:
> Any reason not an enum class?


We | and & the values together which, I believe, you can't do with an enum
class.

[dsinclair, 2016-05-16 19:51:35]

On 2016/05/16 18:39:27, dsinclair wrote:
> https://codereview.chromium.org/1986503002/diff/1/xfa/fxfa/include/fxfa.h
> File xfa/fxfa/include/fxfa.h (right):
> 
>
https://codereview.chromium.org/1986503002/diff/1/xfa/fxfa/include/fxfa.h#new...
> xfa/fxfa/include/fxfa.h:188: enum XFA_WidgetStatus {
> On 2016/05/16 18:36:57, Tom Sepez wrote:
> > Any reason not an enum class?
> 
> 
> We | and & the values together which, I believe, you can't do with an enum
> class.

I seem to have broken something, will ping when fixed.

[dsinclair, 2016-05-16 21:30:15]

On 2016/05/16 19:51:35, dsinclair wrote:
> On 2016/05/16 18:39:27, dsinclair wrote:
> > https://codereview.chromium.org/1986503002/diff/1/xfa/fxfa/include/fxfa.h
> > File xfa/fxfa/include/fxfa.h (right):
> > 
> >
>
https://codereview.chromium.org/1986503002/diff/1/xfa/fxfa/include/fxfa.h#new...
> > xfa/fxfa/include/fxfa.h:188: enum XFA_WidgetStatus {
> > On 2016/05/16 18:36:57, Tom Sepez wrote:
> > > Any reason not an enum class?
> > 
> > 
> > We | and & the values together which, I believe, you can't do with an enum
> > class.
> 
> I seem to have broken something, will ping when fixed.



Turns out XFA_LAYOUTSTATUS is used interchangeably with XFA_WIDGETSTATUS and
since I changed the values this failed. Will look at combining the two status's
into one and will ping the CL when done.

[dsinclair, 2016-05-17 15:59:36]

Description was changed from

==========
XFA_WIDGETSTATUS cleanup.

This CL moves all of the XFA_WIDGETSTATUS values into a single enum instead
of multiple defines. The values are also normalized.

The name was updated to be XFA_WidgetStatus.
==========

to

==========
XFA_WIDGETSTATUS cleanup.

This CL moves all of the XFA_WIDGETSTATUS values into a single enum instead
of multiple defines. The values are also normalized.

The name was updated to be XFA_WidgetStatus.

The XFA_WIDGETFILTER and XFA_LAYOUTSTATUS defines had to
match up to XFA_WIDGETSTATUS. This Cl replaces those so
we just have a single enum to work with.
==========

[dsinclair, 2016-05-17 16:02:47]

PTAL.

Turns out, XFA_WIDGETSTATUS, XFA_WIDGETFILTER and XFA_LAYOUTSTATUS all had to
have certain matching values in order for things to work.

https://codereview.chromium.org/1986503002/diff/20001/xfa/fxfa/app/xfa_ffpage...
File xfa/fxfa/app/xfa_ffpageview.cpp (left):

https://codereview.chromium.org/1986503002/diff/20001/xfa/fxfa/app/xfa_ffpage...
xfa/fxfa/app/xfa_ffpageview.cpp:118: uint32_t dwType = dwFilter &
XFA_WIDGETFILTER_AllType;
As far as I can tell, this check is just to see if the filter contains _Focused,
but not _AllType. So, I removed the AllType and told it to just check for
_Focused.

[Tom Sepez, 2016-05-17 16:51:13]

lgtm

https://codereview.chromium.org/1986503002/diff/40001/xfa/fxfa/app/xfa_ffpage...
File xfa/fxfa/app/xfa_ffpageview.cpp (right):

https://codereview.chromium.org/1986503002/diff/40001/xfa/fxfa/app/xfa_ffpage...
xfa/fxfa/app/xfa_ffpageview.cpp:72: FX_BOOL PageWidgetFilter(CXFA_FFWidget*
pWidget,
can this be bool?

https://codereview.chromium.org/1986503002/diff/40001/xfa/fxfa/app/xfa_ffpage...
xfa/fxfa/app/xfa_ffpageview.cpp:79: (pWidgetAcc->GetClassID() !=
XFA_ELEMENT_Field)) {
nit: second clause overparenthesized.

[dsinclair, 2016-05-17 16:54:25]

https://codereview.chromium.org/1986503002/diff/40001/xfa/fxfa/app/xfa_ffpage...
File xfa/fxfa/app/xfa_ffpageview.cpp (right):

https://codereview.chromium.org/1986503002/diff/40001/xfa/fxfa/app/xfa_ffpage...
xfa/fxfa/app/xfa_ffpageview.cpp:72: FX_BOOL PageWidgetFilter(CXFA_FFWidget*
pWidget,
On 2016/05/17 16:51:13, Tom Sepez wrote:
> can this be bool?

Done.

https://codereview.chromium.org/1986503002/diff/40001/xfa/fxfa/app/xfa_ffpage...
xfa/fxfa/app/xfa_ffpageview.cpp:79: (pWidgetAcc->GetClassID() !=
XFA_ELEMENT_Field)) {
On 2016/05/17 16:51:13, Tom Sepez wrote:
> nit: second clause overparenthesized.

Done.

[dsinclair, 2016-05-17 16:54:40]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-05-17 16:54:40]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1986503002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-05-17 16:54:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1986503002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1986503002/60001

[commit-bot: I haz the power, 2016-05-17 17:32:23]

Description was changed from

==========
XFA_WIDGETSTATUS cleanup.

This CL moves all of the XFA_WIDGETSTATUS values into a single enum instead
of multiple defines. The values are also normalized.

The name was updated to be XFA_WidgetStatus.

The XFA_WIDGETFILTER and XFA_LAYOUTSTATUS defines had to
match up to XFA_WIDGETSTATUS. This Cl replaces those so
we just have a single enum to work with.
==========

to

==========
XFA_WIDGETSTATUS cleanup.

This CL moves all of the XFA_WIDGETSTATUS values into a single enum instead
of multiple defines. The values are also normalized.

The name was updated to be XFA_WidgetStatus.

The XFA_WIDGETFILTER and XFA_LAYOUTSTATUS defines had to
match up to XFA_WIDGETSTATUS. This Cl replaces those so
we just have a single enum to work with.

Committed:
https://pdfium.googlesource.com/pdfium/+/935d8d5dcbf1da2b3198675428cbf7ca0406...
==========

[commit-bot: I haz the power, 2016-05-17 17:32:24]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/935d8d5dcbf1da2b3198675428cbf7ca0406...