Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1986373002: Remove Release() from IFX_CharIter, use unique_ptrs. (Closed)

Created:
4 years, 7 months ago by Tom Sepez
Modified:
4 years, 7 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove Release() from IFX_CharIter, use unique_ptrs. Committed: https://pdfium.googlesource.com/pdfium/+/8bdb290b9301200aeafa8b89678e690166ba1ce6

Patch Set 1 #

Total comments: 1

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -100 lines) Patch
M xfa/fee/fde_txtedtbuf.h View 2 chunks +8 lines, -11 lines 0 comments Download
M xfa/fee/fde_txtedtbuf.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M xfa/fee/fde_txtedtengine.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fee/fde_txtedtpage.h View 2 chunks +3 lines, -1 line 0 comments Download
M xfa/fee/fde_txtedtpage.cpp View 6 chunks +11 lines, -19 lines 0 comments Download
M xfa/fee/fde_txtedtparag.cpp View 4 chunks +4 lines, -5 lines 0 comments Download
M xfa/fee/fx_wordbreak/fx_wordbreak.h View 2 chunks +14 lines, -14 lines 0 comments Download
M xfa/fee/fx_wordbreak/fx_wordbreak_impl.cpp View 1 3 chunks +27 lines, -44 lines 0 comments Download
M xfa/fee/ifde_txtedtengine.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Tom Sepez
Dan, for review.
4 years, 7 months ago (2016-05-17 20:17:42 UTC) #3
dsinclair
lgtm https://codereview.chromium.org/1986373002/diff/1/xfa/fee/fx_wordbreak/fx_wordbreak_impl.cpp File xfa/fee/fx_wordbreak/fx_wordbreak_impl.cpp (right): https://codereview.chromium.org/1986373002/diff/1/xfa/fee/fx_wordbreak/fx_wordbreak_impl.cpp#newcode59 xfa/fee/fx_wordbreak/fx_wordbreak_impl.cpp:59: CFX_WordBreak::~CFX_WordBreak() {} nit: blank line before
4 years, 7 months ago (2016-05-17 20:20:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986373002/20001
4 years, 7 months ago (2016-05-17 20:42:37 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 20:42:55 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/8bdb290b9301200aeafa8b89678e690166ba...

Powered by Google App Engine
This is Rietveld 408576698