xfa/fee/ifde_txtedtengine.h - Issue 1986373002: Remove Release() from IFX_CharIter, use unique_ptrs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: xfa/fee/ifde_txtedtengine.h

Issue 1986373002: Remove Release() from IFX_CharIter, use unique_ptrs. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Nit Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « xfa/fee/fx_wordbreak/fx_wordbreak_impl.cpp ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef XFA_FEE_IFDE_TXTEDTENGINE_H_	7 #ifndef XFA_FEE_IFDE_TXTEDTENGINE_H_

8 #define XFA_FEE_IFDE_TXTEDTENGINE_H_	8 #define XFA_FEE_IFDE_TXTEDTENGINE_H_

9	9

10 #include "core/fxge/include/fx_dib.h"	10 #include "core/fxge/include/fx_dib.h"

(...skipping 124 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
135 struct FDE_TXTEDT_TEXTCHANGE_INFO {	135 struct FDE_TXTEDT_TEXTCHANGE_INFO {

136 int32_t nChangeType;	136 int32_t nChangeType;

137 CFX_WideString wsInsert;	137 CFX_WideString wsInsert;

138 CFX_WideString wsDelete;	138 CFX_WideString wsDelete;

139 CFX_WideString wsPrevText;	139 CFX_WideString wsPrevText;

140 };	140 };

141	141

142 class IFX_CharIter {	142 class IFX_CharIter {

143 public:	143 public:

144 virtual ~IFX_CharIter() {}	144 virtual ~IFX_CharIter() {}

145 virtual void Release() = 0;	145

146 virtual FX_BOOL Next(FX_BOOL bPrev = FALSE) = 0;	146 virtual FX_BOOL Next(FX_BOOL bPrev = FALSE) = 0;

147 virtual FX_WCHAR GetChar() = 0;	147 virtual FX_WCHAR GetChar() = 0;

148 virtual void SetAt(int32_t nIndex) = 0;	148 virtual void SetAt(int32_t nIndex) = 0;

149 virtual int32_t GetAt() const = 0;	149 virtual int32_t GetAt() const = 0;

150 virtual FX_BOOL IsEOF(FX_BOOL bTail = TRUE) const = 0;	150 virtual FX_BOOL IsEOF(FX_BOOL bTail = TRUE) const = 0;

151 virtual IFX_CharIter* Clone() = 0;	151 virtual IFX_CharIter* Clone() = 0;

152 };	152 };

153	153

154 #endif // XFA_FEE_IFDE_TXTEDTENGINE_H_	154 #endif // XFA_FEE_IFDE_TXTEDTENGINE_H_

OLD	NEW