Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 1986113004: Add cmpxchg and lock instructions to x64 and ia32 {dis,}assemblers (Closed)

Created:
4 years, 7 months ago by binji
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add cmpxchg and lock instructions to x64 and ia32 {dis,}assemblers Committed: https://crrev.com/5c22cf5ae7a7989669a363f783f9bd625bdacec5 Cr-Commit-Position: refs/heads/master@{#36341}

Patch Set 1 #

Patch Set 2 : fix test #

Patch Set 3 : merge master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -6 lines) Patch
M src/ia32/assembler-ia32.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 1 5 chunks +23 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.h View 4 chunks +12 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M src/x64/disasm-x64.cc View 5 chunks +14 lines, -2 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
binji
4 years, 7 months ago (2016-05-17 22:10:55 UTC) #2
Benedikt Meurer
LGTM modulo test failures.
4 years, 7 months ago (2016-05-18 04:54:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986113004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986113004/40001
4 years, 7 months ago (2016-05-19 00:52:52 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-19 00:55:19 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 00:56:15 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5c22cf5ae7a7989669a363f783f9bd625bdacec5
Cr-Commit-Position: refs/heads/master@{#36341}

Powered by Google App Engine
This is Rietveld 408576698