Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1986083003: [Mac][Material Design] Fix toolbar height regression. (Closed)

Created:
4 years, 7 months ago by shrike
Modified:
4 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Fix toolbar height regression. Fix a toolbar height regression on non-Retina Mac introduced in https://codereview.chromium.org/1948963002 . R=avi@chromium.org BUG=611746 Committed: https://crrev.com/a128b79566a12f910fda7acfb9ee671c8dbd2705 Cr-Commit-Position: refs/heads/master@{#394430}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shrike
PTAL
4 years, 7 months ago (2016-05-17 22:03:31 UTC) #1
Avi (use Gerrit)
lgtm
4 years, 7 months ago (2016-05-17 23:30:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986083003/1
4 years, 7 months ago (2016-05-18 15:08:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 15:44:30 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 15:46:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a128b79566a12f910fda7acfb9ee671c8dbd2705
Cr-Commit-Position: refs/heads/master@{#394430}

Powered by Google App Engine
This is Rietveld 408576698