[Mac][Material Design] Fix toolbar height on Retina.

[Mac][Material Design] Fix toolbar height on Retina.

A recent change to center the toolbar's buttons and textfield on
Retina displays throws them off-center on Retina when in Material
Design. This change bypasses the adjustment in this case.

Note that on Retina there is an odd number of pixels between the top
and bottom edges of the toolbar, which means that the location bar's
contents cannot be exactly centered. This is per spec (it also
occurs on ChromeOS).

Lastly, this cl makes the location bar shadow color transparent.

R=avi@chromium.org
BUG=605140
Committed: https://crrev.com/90b73afb789c6a84ce25579c08bb4ac55164c768
Cr-Commit-Position: refs/heads/master@{#392379}

[shrike, 2016-05-05 17:45:35]

Description was changed from

==========
[Mac][Material Design] Fix toolbar height on Retina.

A change that centers the toolbar items on Retina non-Material throws
them off-center on Retina Material. This change cancels out the
adjustment in this case.

This change also adds a faint shadow under the location bar on Retina
Material to try give the appearance that the location bar is centered.
On Retina there is an odd number of pixels between the top edge of the
toolbar and the bottom edge. The location bar's even height means that
it can't be centered.

Lastly, this cl makes the locatino bar shadow color transparent.

BUG=605140
==========

to

==========
[Mac][Material Design] Fix toolbar height on Retina.

A change that centers the toolbar items on Retina non-Material throws
them off-center on Retina Material. This change cancels out the
adjustment in this case.

This change also adds a faint shadow under the location bar on Retina
Material to try give the appearance that the location bar is centered.
On Retina there is an odd number of pixels between the top edge of the
toolbar and the bottom edge. The location bar's even height means that
it can't be centered.

Lastly, this cl makes the location bar shadow color transparent.

BUG=605140
==========

[shrike, 2016-05-07 14:17:22]

Description was changed from

==========
[Mac][Material Design] Fix toolbar height on Retina.

A change that centers the toolbar items on Retina non-Material throws
them off-center on Retina Material. This change cancels out the
adjustment in this case.

This change also adds a faint shadow under the location bar on Retina
Material to try give the appearance that the location bar is centered.
On Retina there is an odd number of pixels between the top edge of the
toolbar and the bottom edge. The location bar's even height means that
it can't be centered.

Lastly, this cl makes the location bar shadow color transparent.

BUG=605140
==========

to

==========
[Mac][Material Design] Fix toolbar height on Retina.

A recent change to center the toolbar's buttons and textfield on
Retina displays throws them off-center on Retina when in Material
Design. This change bypasses the adjustment in this case.

Note that on Retina there is an odd number of pixels between the top
and bottom edges of the toolbar, which means that the location bar's
contents cannot be exactly centered. This is per spec (it also
occurs on ChromeOS).

Lastly, this cl makes the location bar shadow color transparent.

R=avi@chromium.org
BUG=605140
==========

[shrike, 2016-05-07 14:17:22]

shrike@chromium.org changed reviewers:
+ avi@chromium.org

[shrike, 2016-05-07 14:21:02]

PTAL

[Avi (use Gerrit), 2016-05-07 15:12:24]

https://codereview.chromium.org/1948963002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm (right):

https://codereview.chromium.org/1948963002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm:1039: // When on a
Retina display, -[ToolbarContrller baseToolbarHeight] reduces
Typo: "ToolbarContrller"

I know that we're at 80 columns here, but you can fix the comment to be "When on
a Retina display and not using Material Design..." to fill the space.

Also, re the comment, how does this affect the spacing between the bookmark
icons and toolbar items?

[shrike, 2016-05-07 18:22:34]

PTAL

https://codereview.chromium.org/1948963002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm (right):

https://codereview.chromium.org/1948963002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm:1039: // When on a
Retina display, -[ToolbarContrller baseToolbarHeight] reduces
On 2016/05/07 15:12:24, Avi wrote:
> Typo: "ToolbarContrller"
> 
> I know that we're at 80 columns here, but you can fix the comment to be "When
on
> a Retina display and not using Material Design..." to fill the space.
> 
> Also, re the comment, how does this affect the spacing between the bookmark
> icons and toolbar items?

Done (and I beefed up the comment re: bookmark icon spacing).

[Avi (use Gerrit), 2016-05-07 18:54:07]

lgtm

[shrike, 2016-05-09 16:25:12]

The CQ bit was checked by shrike@chromium.org

[shrike, 2016-05-09 16:25:23]

The CQ bit was unchecked by shrike@chromium.org

[commit-bot: I haz the power, 2016-05-09 16:25:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1948963002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1948963002/40001

[shrike, 2016-05-09 18:00:20]

The CQ bit was checked by shrike@chromium.org

[commit-bot: I haz the power, 2016-05-09 18:01:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1948963002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1948963002/40001

[commit-bot: I haz the power, 2016-05-09 18:41:44]

Description was changed from

==========
[Mac][Material Design] Fix toolbar height on Retina.

A recent change to center the toolbar's buttons and textfield on
Retina displays throws them off-center on Retina when in Material
Design. This change bypasses the adjustment in this case.

Note that on Retina there is an odd number of pixels between the top
and bottom edges of the toolbar, which means that the location bar's
contents cannot be exactly centered. This is per spec (it also
occurs on ChromeOS).

Lastly, this cl makes the location bar shadow color transparent.

R=avi@chromium.org
BUG=605140
==========

to

==========
[Mac][Material Design] Fix toolbar height on Retina.

A recent change to center the toolbar's buttons and textfield on
Retina displays throws them off-center on Retina when in Material
Design. This change bypasses the adjustment in this case.

Note that on Retina there is an odd number of pixels between the top
and bottom edges of the toolbar, which means that the location bar's
contents cannot be exactly centered. This is per spec (it also
occurs on ChromeOS).

Lastly, this cl makes the location bar shadow color transparent.

R=avi@chromium.org
BUG=605140
==========

[commit-bot: I haz the power, 2016-05-09 18:41:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-09 18:43:00]

Description was changed from

==========
[Mac][Material Design] Fix toolbar height on Retina.

A recent change to center the toolbar's buttons and textfield on
Retina displays throws them off-center on Retina when in Material
Design. This change bypasses the adjustment in this case.

Note that on Retina there is an odd number of pixels between the top
and bottom edges of the toolbar, which means that the location bar's
contents cannot be exactly centered. This is per spec (it also
occurs on ChromeOS).

Lastly, this cl makes the location bar shadow color transparent.

R=avi@chromium.org
BUG=605140
==========

to

==========
[Mac][Material Design] Fix toolbar height on Retina.

A recent change to center the toolbar's buttons and textfield on
Retina displays throws them off-center on Retina when in Material
Design. This change bypasses the adjustment in this case.

Note that on Retina there is an odd number of pixels between the top
and bottom edges of the toolbar, which means that the location bar's
contents cannot be exactly centered. This is per spec (it also
occurs on ChromeOS).

Lastly, this cl makes the location bar shadow color transparent.

R=avi@chromium.org
BUG=605140

Committed: https://crrev.com/90b73afb789c6a84ce25579c08bb4ac55164c768
Cr-Commit-Position: refs/heads/master@{#392379}
==========

[commit-bot: I haz the power, 2016-05-09 18:43:01]

Patchset 3 (id:??) landed as
https://crrev.com/90b73afb789c6a84ce25579c08bb4ac55164c768
Cr-Commit-Position: refs/heads/master@{#392379}

[shrike, 2016-08-30 17:40:13]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2294733004/ by shrike@chromium.org.

The reason for reverting is: Testing for cause of regression..