Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1986083002: Check RawResourceClient destruction in RawResource::didAddClient() (Closed)

Created:
4 years, 7 months ago by hiroshige
Modified:
4 years, 7 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check RawResourceClient destruction in RawResource::didAddClient() BUG=612132 Committed: https://crrev.com/642f15021cf5907ffdc26d919b9870cd567caf89 Cr-Commit-Position: refs/heads/master@{#394331}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M third_party/WebKit/Source/core/fetch/RawResource.h View 3 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/RawResource.cpp View 1 chunk +4 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986083002/1
4 years, 7 months ago (2016-05-17 08:53:25 UTC) #2
hiroshige
PTAL.
4 years, 7 months ago (2016-05-17 08:53:51 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-17 11:18:22 UTC) #6
yhirano
(I made this issue protected)
4 years, 7 months ago (2016-05-17 12:53:14 UTC) #8
yhirano
ResourceClientOrObserverWalker has the same problem, but it's not very exploitable at this moment, so you ...
4 years, 7 months ago (2016-05-17 13:53:56 UTC) #9
hiroshige
On 2016/05/17 13:53:56, yhirano wrote: > ResourceClientOrObserverWalker has the same problem Yes, I think so. ...
4 years, 7 months ago (2016-05-17 13:57:26 UTC) #10
yhirano
lgtm
4 years, 7 months ago (2016-05-17 14:00:21 UTC) #11
hiroshige
Nate, could you take a look?
4 years, 7 months ago (2016-05-17 17:24:40 UTC) #12
Nate Chapin
I'm sad this is necessary :/ LGTM
4 years, 7 months ago (2016-05-17 21:07:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986083002/1
4 years, 7 months ago (2016-05-18 04:10:28 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 04:15:11 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 04:16:25 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/642f15021cf5907ffdc26d919b9870cd567caf89
Cr-Commit-Position: refs/heads/master@{#394331}

Powered by Google App Engine
This is Rietveld 408576698