Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: third_party/WebKit/Source/core/fetch/RawResource.h

Issue 1986083002: Check RawResourceClient destruction in RawResource::didAddClient() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/fetch/RawResource.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org> 3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org>
4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
5 Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 6
7 This library is free software; you can redistribute it and/or 7 This library is free software; you can redistribute it and/or
8 modify it under the terms of the GNU Library General Public 8 modify it under the terms of the GNU Library General Public
9 License as published by the Free Software Foundation; either 9 License as published by the Free Software Foundation; either
10 version 2 of the License, or (at your option) any later version. 10 version 2 of the License, or (at your option) any later version.
(...skipping 10 matching lines...) Expand all
21 */ 21 */
22 22
23 #ifndef RawResource_h 23 #ifndef RawResource_h
24 #define RawResource_h 24 #define RawResource_h
25 25
26 #include "core/CoreExport.h" 26 #include "core/CoreExport.h"
27 #include "core/fetch/Resource.h" 27 #include "core/fetch/Resource.h"
28 #include "core/fetch/ResourceClient.h" 28 #include "core/fetch/ResourceClient.h"
29 #include "public/platform/WebDataConsumerHandle.h" 29 #include "public/platform/WebDataConsumerHandle.h"
30 #include "wtf/PassOwnPtr.h" 30 #include "wtf/PassOwnPtr.h"
31 #include "wtf/WeakPtr.h"
31 32
32 namespace blink { 33 namespace blink {
33 class FetchRequest; 34 class FetchRequest;
34 class RawResourceClient; 35 class RawResourceClient;
35 class ResourceFetcher; 36 class ResourceFetcher;
36 class SubstituteData; 37 class SubstituteData;
37 38
38 class CORE_EXPORT RawResource final : public Resource { 39 class CORE_EXPORT RawResource final : public Resource {
39 public: 40 public:
40 using ClientType = RawResourceClient; 41 using ClientType = RawResourceClient;
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 } 97 }
97 #endif 98 #endif
98 inline RawResource* toRawResource(Resource* resource) 99 inline RawResource* toRawResource(Resource* resource)
99 { 100 {
100 ASSERT_WITH_SECURITY_IMPLICATION(!resource || isRawResource(*resource)); 101 ASSERT_WITH_SECURITY_IMPLICATION(!resource || isRawResource(*resource));
101 return static_cast<RawResource*>(resource); 102 return static_cast<RawResource*>(resource);
102 } 103 }
103 104
104 class CORE_EXPORT RawResourceClient : public ResourceClient { 105 class CORE_EXPORT RawResourceClient : public ResourceClient {
105 public: 106 public:
107 RawResourceClient()
108 : m_weakFactory(this) { }
109 WeakPtr<RawResourceClient> createWeakPtr() { return m_weakFactory.createWeak Ptr(); }
106 ~RawResourceClient() override {} 110 ~RawResourceClient() override {}
107 static bool isExpectedType(ResourceClient* client) { return client->getResou rceClientType() == RawResourceType; } 111 static bool isExpectedType(ResourceClient* client) { return client->getResou rceClientType() == RawResourceType; }
108 ResourceClientType getResourceClientType() const final { return RawResourceT ype; } 112 ResourceClientType getResourceClientType() const final { return RawResourceT ype; }
109 113
110 virtual void dataSent(Resource*, unsigned long long /* bytesSent */, unsigne d long long /* totalBytesToBeSent */) { } 114 virtual void dataSent(Resource*, unsigned long long /* bytesSent */, unsigne d long long /* totalBytesToBeSent */) { }
111 virtual void responseReceived(Resource*, const ResourceResponse&, PassOwnPtr <WebDataConsumerHandle>) { } 115 virtual void responseReceived(Resource*, const ResourceResponse&, PassOwnPtr <WebDataConsumerHandle>) { }
112 virtual void setSerializedCachedMetadata(Resource*, const char*, size_t) { } 116 virtual void setSerializedCachedMetadata(Resource*, const char*, size_t) { }
113 virtual void dataReceived(Resource*, const char* /* data */, size_t /* lengt h */) { } 117 virtual void dataReceived(Resource*, const char* /* data */, size_t /* lengt h */) { }
114 virtual void redirectReceived(Resource*, ResourceRequest&, const ResourceRes ponse&) { } 118 virtual void redirectReceived(Resource*, ResourceRequest&, const ResourceRes ponse&) { }
115 virtual void redirectBlocked() {} 119 virtual void redirectBlocked() {}
116 virtual void dataDownloaded(Resource*, int) { } 120 virtual void dataDownloaded(Resource*, int) { }
117 virtual void didReceiveResourceTiming(Resource*, const ResourceTimingInfo&) { } 121 virtual void didReceiveResourceTiming(Resource*, const ResourceTimingInfo&) { }
122
123 private:
124 WeakPtrFactory<RawResourceClient> m_weakFactory;
118 }; 125 };
119 126
120 } // namespace blink 127 } // namespace blink
121 128
122 #endif // RawResource_h 129 #endif // RawResource_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/fetch/RawResource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698