Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1986073003: Expired studies should not enable features. (Closed)

Created:
4 years, 7 months ago by Alexei Svitkine (slow)
Modified:
4 years, 7 months ago
Reviewers:
jwd
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expired studies should not enable features. Previosuly, the "chosen group" was queried before an expired study was marked as enabled, which resulted in the wrong features being activated/de-activated for disabled studies (i.e. it would apply the ones based on the dice roll, rather then the default group ones). This CL fixes that and adds a test. BUG=612533 Committed: https://crrev.com/7141106df26d989fa4a37bee08a0353fa84901ab Cr-Commit-Position: refs/heads/master@{#394202}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -40 lines) Patch
M components/variations/variations_seed_processor.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/variations/variations_seed_processor_unittest.cc View 23 chunks +97 lines, -37 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Alexei Svitkine (slow)
4 years, 7 months ago (2016-05-17 18:54:03 UTC) #3
jwd
lgtm
4 years, 7 months ago (2016-05-17 19:27:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986073003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986073003/20001
4 years, 7 months ago (2016-05-17 19:46:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-17 20:10:00 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 20:11:07 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7141106df26d989fa4a37bee08a0353fa84901ab
Cr-Commit-Position: refs/heads/master@{#394202}

Powered by Google App Engine
This is Rietveld 408576698