Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1596)

Unified Diff: components/variations/variations_seed_processor.cc

Issue 1986073003: Expired studies should not enable features. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/variations/variations_seed_processor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/variations/variations_seed_processor.cc
diff --git a/components/variations/variations_seed_processor.cc b/components/variations/variations_seed_processor.cc
index f22848afa57a4b1e055f64437a557291dd0ffa53..4c6241d53de9d1531a153cd857487e2f377e045a 100644
--- a/components/variations/variations_seed_processor.cc
+++ b/components/variations/variations_seed_processor.cc
@@ -281,13 +281,13 @@ void VariationsSeedProcessor::CreateTrialFromStudy(
}
trial->SetForced();
+ if (processed_study.is_expired())
+ trial->Disable();
if (enables_or_disables_features)
RegisterFeatureOverrides(processed_study, trial.get(), feature_list);
- if (processed_study.is_expired()) {
- trial->Disable();
- } else if (study.activation_type() == Study_ActivationType_ACTIVATION_AUTO) {
+ if (study.activation_type() == Study_ActivationType_ACTIVATION_AUTO) {
const std::string& group_name = trial->group_name();
// Don't try to apply overrides if none of the experiments in this study had
« no previous file with comments | « no previous file | components/variations/variations_seed_processor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698