third_party/WebKit/Source/core/paint/BoxClipper.cpp - Issue 1985933002: Don't clip composited scrolling contain:paint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/BoxClipper.cpp

Issue 1985933002: Don't clip composited scrolling contain:paint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/BoxClipper.cpp

diff --git a/third_party/WebKit/Source/core/paint/BoxClipper.cpp b/third_party/WebKit/Source/core/paint/BoxClipper.cpp

index d8697eacc8087fb242e63e63e8c95fde16327f0f..c653edffa7e116fc4a761ba4a4f11344c89965a1 100644

--- a/third_party/WebKit/Source/core/paint/BoxClipper.cpp

+++ b/third_party/WebKit/Source/core/paint/BoxClipper.cpp

@@ -36,8 +36,7 @@ BoxClipper::BoxClipper(const LayoutBox& box, const PaintInfo& paintInfo, const L

}

bool isControlClip = m_box.hasControlClip();

- bool isOverflowOrContainmentClip = (m_box.hasOverflowClip() && !m_box.layer()->isSelfPaintingLayer())

- || m_box.style()->containsPaint();

+ bool isOverflowOrContainmentClip = (m_box.hasOverflowClip() || box.styleRef().containsPaint()) && !m_box.layer()->isSelfPaintingLayer();

if (!isControlClip && !isOverflowOrContainmentClip)

return;