blimp/engine/mojo/blob_channel.mojom - Issue 1985863002: Incorporate BlobChannel into Blimp image encode/decode pipeline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/engine/mojo/blob_channel.mojom

Issue 1985863002: Incorporate BlobChannel into Blimp image encode/decode pipeline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blobchannel-helium

Patch Set: Decoupled BlobChannelSenderHost from mojom::BlobChannel Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/engine/app/blimp_browser_main_parts.h ('K') | « blimp/engine/app/blimp_content_browser_client.cc ('k') | blimp/engine/mojo/blob_channel_service.h » ('j') | blimp/engine/mojo/blob_channel_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/engine/mojo/blob_channel.mojom

diff --git a/blimp/engine/mojo/blob_channel.mojom b/blimp/engine/mojo/blob_channel.mojom

index fe3ebb9dc4734f6a6950387739cc04afc5f7b899..ff18bba6ecf50efc06fd47de89e09dba96ec72ac 100644

--- a/blimp/engine/mojo/blob_channel.mojom

+++ b/blimp/engine/mojo/blob_channel.mojom

@@ -6,7 +6,8 @@ module blimp.engine.mojom;

interface BlobChannel {

// Stores the blob |id| in the BlobCache.

- Put(string id, array<uint8> data);

+ // TODO(kmarshall): Use shared memory for more efficient data transfer.

Wez 2016/05/21 01:08:04 nit: File a bug for that work and include the bug

Kevin M 2016/05/27 22:35:30 Done.

+ Put(string id, string data);

// Requests that the BlobChannel push the blob |id| over the wire.

// The request will be ignored if the BlobChannel knows that