blimp/engine/mojo/blob_channel.mojom - Issue 1985863002: Incorporate BlobChannel into Blimp image encode/decode pipeline.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/engine/mojo/blob_channel.mojom

Issue 1985863002: Incorporate BlobChannel into Blimp image encode/decode pipeline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blobchannel-helium

Patch Set: Decoupled BlobChannelSenderHost from mojom::BlobChannel Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« blimp/engine/app/blimp_browser_main_parts.h ('K') | « blimp/engine/app/blimp_content_browser_client.cc ('k') | blimp/engine/mojo/blob_channel_service.h » ('j') | blimp/engine/mojo/blob_channel_service.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module blimp.engine.mojom;	5 module blimp.engine.mojom;

6	6

7 interface BlobChannel {	7 interface BlobChannel {

8 // Stores the blob \|id\| in the BlobCache.	8 // Stores the blob \|id\| in the BlobCache.

9 Put(string id, array<uint8> data);	9 // TODO(kmarshall): Use shared memory for more efficient data transfer.
	Wez 2016/05/21 01:08:04 nit: File a bug for that work and include the bug nit: File a bug for that work and include the bug # here. Kevin M 2016/05/27 22:35:30 Done. Show quoted text On 2016/05/21 01:08:04, Wez wrote: > nit: File a bug for that work and include the bug # here. Done.
	10 Put(string id, string data);

10	11

11 // Requests that the BlobChannel push the blob \|id\| over the wire.	12 // Requests that the BlobChannel push the blob \|id\| over the wire.

12 // The request will be ignored if the BlobChannel knows that	13 // The request will be ignored if the BlobChannel knows that

13 // the client already has the data.	14 // the client already has the data.

14 Push(string id);	15 Push(string id);

15 };	16 };

16	17

OLD	NEW