Use chromium_code standard for PDFium GYP compilation

Use chromium_code standard for PDFium GYP compilation

Define and use chromium_code to be used in standalone PDFium GYP
build so that PDFium code can have more stringent warning level.

This is also enabled on GN build by default so that GYP and GN
builds can have consistent compilation results.

Also enable chromium_code for PDFium compilation in Chromium
since most of the warnings are cleared. The left ones are clearly
marked and will be addressed soon.

A few more clean-ups for the build:

-- Remove the suppression of sign-compare warnings for Clang since
the code is clean and the warning can be re-enabled.
-- Re-enable "treat warning as errors" on Mac
-- Add a flag to make GCC build works as well.

BUG=pdfium:29, pdfium:475
Committed: https://pdfium.googlesource.com/pdfium/+/5f3b41bca725090391b9053a9435c86fa7b22df1

[Wei Li, 2016-05-16 21:00:58]

Description was changed from

==========
Use chromium_code standard for PDFium GYP compilation

Define and use chromium_code to be used in standalone PDFium GYP
build so that PDFium code can have more stringent warning level.

This is also enabled on GN build by default so that GYP and GN
builds can have consistent compilation results.

Also enable chromium_code for PDFium compilation in Chromium
since most of the warnings are cleared. The left ones are clearly
marked and will be addressed soon.

A few more clean-ups for the build:

-- Remove the suppression of sign-compare warnings for Clang since
the code is clean and the warning can be re-enabled.
-- Re-enable "treat warning as errors" on Mac
-- Change a condition to make GCC build works as well.

BUG=pdfium:29, pdfium:475
==========

to

==========
Use chromium_code standard for PDFium GYP compilation

Define and use chromium_code to be used in standalone PDFium GYP
build so that PDFium code can have more stringent warning level.

This is also enabled on GN build by default so that GYP and GN
builds can have consistent compilation results.

Also enable chromium_code for PDFium compilation in Chromium
since most of the warnings are cleared. The left ones are clearly
marked and will be addressed soon.

A few more clean-ups for the build:

-- Remove the suppression of sign-compare warnings for Clang since
the code is clean and the warning can be re-enabled.
-- Re-enable "treat warning as errors" on Mac
-- Add a flag to make GCC build works as well.

BUG=pdfium:29, pdfium:475
==========

[Wei Li, 2016-05-16 23:43:40]

weili@chromium.org changed reviewers:
+ thakis@chromium.org

[Wei Li, 2016-05-16 23:43:40]

Pls review, thanks

[Nico, 2016-05-16 23:47:45]

Nice!

https://codereview.chromium.org/1985843002/diff/1/third_party/third_party.gyp
File third_party/third_party.gyp (right):

https://codereview.chromium.org/1985843002/diff/1/third_party/third_party.gyp...
third_party/third_party.gyp:7: 'chromium_code': 0,
This defaults to 0, do you need this?

https://codereview.chromium.org/1985843002/diff/1/third_party/third_party.gyp...
third_party/third_party.gyp:92: # ftbase.h are unused. GCC needs this flag too.
Won't it be needed for clang-cl as well? Maybe it should be in clang_warning
flags, and also in an os_posix==1 and clang==0 block

[Wei Li, 2016-05-17 00:23:24]

ptal, thanks

https://codereview.chromium.org/1985843002/diff/1/third_party/third_party.gyp
File third_party/third_party.gyp (right):

https://codereview.chromium.org/1985843002/diff/1/third_party/third_party.gyp...
third_party/third_party.gyp:7: 'chromium_code': 0,
On 2016/05/16 23:47:45, Nico (vacation May 19 to 22) wrote:
> This defaults to 0, do you need this?

Done.

https://codereview.chromium.org/1985843002/diff/1/third_party/third_party.gyp...
third_party/third_party.gyp:92: # ftbase.h are unused. GCC needs this flag too.
On 2016/05/16 23:47:45, Nico (vacation May 19 to 22) wrote:
> Won't it be needed for clang-cl as well? Maybe it should be in clang_warning
> flags, and also in an os_posix==1 and clang==0 block

Yes, clang_warning_flags on line 97 added this flag already. Changed this block
with clang==0.

[Nico, 2016-05-17 00:25:54]

lgtm

[Wei Li, 2016-05-17 00:29:28]

The CQ bit was checked by weili@chromium.org

[commit-bot: I haz the power, 2016-05-17 00:29:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1985843002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1985843002/20001

[commit-bot: I haz the power, 2016-05-17 00:52:20]

Description was changed from

==========
Use chromium_code standard for PDFium GYP compilation

Define and use chromium_code to be used in standalone PDFium GYP
build so that PDFium code can have more stringent warning level.

This is also enabled on GN build by default so that GYP and GN
builds can have consistent compilation results.

Also enable chromium_code for PDFium compilation in Chromium
since most of the warnings are cleared. The left ones are clearly
marked and will be addressed soon.

A few more clean-ups for the build:

-- Remove the suppression of sign-compare warnings for Clang since
the code is clean and the warning can be re-enabled.
-- Re-enable "treat warning as errors" on Mac
-- Add a flag to make GCC build works as well.

BUG=pdfium:29, pdfium:475
==========

to

==========
Use chromium_code standard for PDFium GYP compilation

Define and use chromium_code to be used in standalone PDFium GYP
build so that PDFium code can have more stringent warning level.

This is also enabled on GN build by default so that GYP and GN
builds can have consistent compilation results.

Also enable chromium_code for PDFium compilation in Chromium
since most of the warnings are cleared. The left ones are clearly
marked and will be addressed soon.

A few more clean-ups for the build:

-- Remove the suppression of sign-compare warnings for Clang since
the code is clean and the warning can be re-enabled.
-- Re-enable "treat warning as errors" on Mac
-- Add a flag to make GCC build works as well.

BUG=pdfium:29, pdfium:475

Committed:
https://pdfium.googlesource.com/pdfium/+/5f3b41bca725090391b9053a9435c86fa7b2...
==========

[commit-bot: I haz the power, 2016-05-17 00:52:21]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/5f3b41bca725090391b9053a9435c86fa7b2...