Use chromium_code standard for PDFium GYP compilation

build_gyp/standalone.gypi

 # Copyright 2014 PDFium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Definitions to be used when building stand-alone PDFium binaries.
 
 {
   'variables': {
     'component%': 'static_library',
+    'chromium_code%': 0,
     'clang%': 0,
     'asan%': 0,
     'sanitizer_coverage%': 0,
     'use_goma%': 0,
     'gomadir%': '',
     'msvs_multi_core_compile%': '1',
     'pdf_enable_xfa%': 1,
     'variables': {
       'variables': {
         'variables': {
@@ skipping 145 matching lines @@
         'msvs_configuration_platform': 'x64',
       },
       'Release_x64': {
         'inherit_from': ['Release'],
         'msvs_configuration_platform': 'x64',
       },
     },
     'cflags': [
       '-Wall',
       '-Werror',
-      '-W',
+      '-Wextra',
+      # Two common warning flags for Clang and GCC.
       '-Wno-missing-field-initializers',
-      # Code might someday be made clean for -Wsign-compare, but for now
-      # this produces too much noise to be useful.
-      '-Wno-sign-compare',
       '-Wno-unused-parameter',
       '-pthread',
       '-fno-exceptions',
       '-fvisibility=hidden',
     ],
     'cflags_cc': [
       '-std=c++11',
       # Add back when ICU is clean
       # '-Wnon-virtual-dtor',
       '-fno-rtti',
@@ skipping 163 matching lines @@
         # SubSystem values:
         #   0 == not set
         #   1 == /SUBSYSTEM:CONSOLE
         #   2 == /SUBSYSTEM:WINDOWS
         'SubSystem': '1',
       },
     },
     'xcode_settings': {
       'ALWAYS_SEARCH_USER_PATHS': 'NO',
       'CLANG_CXX_LANGUAGE_STANDARD': 'c++11',
+      'CLANG_CXX_LIBRARY': 'libc++',            # -stdlib=libc++
       'GCC_CW_ASM_SYNTAX': 'NO',                # No -fasm-blocks
       'GCC_DYNAMIC_NO_PIC': 'NO',               # No -mdynamic-no-pic
                                                 # (Equivalent to -fPIC)
       'GCC_ENABLE_CPP_EXCEPTIONS': 'NO',        # -fno-exceptions
       'GCC_ENABLE_CPP_RTTI': 'NO',              # -fno-rtti
       'GCC_ENABLE_PASCAL_STRINGS': 'NO',        # No -mpascal-strings
       # GCC_INLINES_ARE_PRIVATE_EXTERN maps to -fvisibility-inlines-hidden
       'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES',
       'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES',      # -fvisibility=hidden
       'GCC_TREAT_WARNINGS_AS_ERRORS': 'NO',     # -Werror
       'GCC_WARN_NON_VIRTUAL_DESTRUCTOR': 'YES', # -Wnon-virtual-dtor
+      'MACOSX_DEPLOYMENT_TARGET': '10.7',       # -mmacosx-version-min
       'SYMROOT': '<(DEPTH)/xcodebuild',
       'USE_HEADERMAP': 'NO',
       'OTHER_CFLAGS': [
         '-fno-strict-aliasing',
       ],
       'WARNING_CFLAGS': [
         '-Wall',
-        '-Wendif-labels',
-        '-W',
+        '-Werror',
+        '-Wextra',
         '-Wno-unused-parameter',
       ],
     },
     'variables': {
+      'chromium_code%': '<(chromium_code)',
       'clang_warning_flags': [
         # TODO(thakis): https://crbug.com/604888
         '-Wno-undefined-var-template',
       ],
     },
     'includes': [ 'set_clang_warning_flags.gypi', ],
     'conditions': [
       ['component=="shared_library"', {
         'cflags': [
           '-fPIC',
@@ skipping 65 matching lines @@
       }],  # v8_use_external_startup_data==1
       ['clang==1 or host_clang==1', {
         # This is here so that all files get recompiled after a clang roll and
         # when turning clang on or off.
         # (defines are passed via the command line, and build systems rebuild
         # things when their commandline changes). Nothing should ever read this
         # define.
         'defines': ['CR_CLANG_REVISION=<!(python <(DEPTH)/tools/clang/scripts/update.py --print-revision)'],
       }],
     ],
+    'target_conditions': [
+      ['chromium_code==0', {
+        'variables': {
+          'clang_warning_flags': [
+            # Suppress unused variable warnings from third-party libraries.
+            '-Wno-unused-variable',
+          ],
+        },
+        'msvs_settings': {
+          'VCCLCompilerTool': {
+            'WarningLevel': '3',
+          },
+        },
+        'conditions': [
+          ['OS!="win"', {
+            # Remove -Wextra for third-party code.
+            'cflags!': [ '-Wextra' ],
+          }],
+          ['OS!="win" and clang==0', {
+            'cflags!': [
+              '-Wall',
+            ],
+          }],
+          ['OS=="mac"', {
+            'xcode_settings': {
+              'WARNING_CFLAGS!': ['-Wextra'],
+            },
+          }],
+        ],
+      }, {  # chromium_code==1
+        'msvs_settings': {
+          'VCCLCompilerTool': {
+            'WarningLevel': '4',
+          },
+        },
+      }],
+    ],  # target_conditions for 'target_defaults'
   },
   'conditions': [
     ['OS=="linux" or OS=="mac"', {
       'conditions': [
         ['clang==1', {
           'make_global_settings': [
             ['CC', '<(clang_dir)/bin/clang'],
             ['CXX', '<(clang_dir)/bin/clang++'],
           ],
         }],
       ],
     }],  # OS=="linux" or OS=="mac"
     ['OS=="win"', {
       'conditions': [
         ['clang==1', {
           'make_global_settings': [
             ['CC', '<(clang_dir)/bin/clang-cl'],
           ],
         }],
       ],
     }],  # OS=="win"
     ["use_goma==1", {
       'make_global_settings': [
         ['CC_wrapper', '<(gomadir)/gomacc'],
         ['CXX_wrapper', '<(gomadir)/gomacc'],
       ],
     }],  # use_goma==1
   ],
 }