* Removed QuicTag kQuicVersion1

* Removed QuicTag kQuicVersion1
* Replaced this with enum QuicVersion, which currently has QUIC_VERSION_6
  and QUIC_VERSION_7
* End to end tests are run with both versions
* Framer tests are run with both versions
* QuicConnection now takes a QuicVersion parameter
* TimeWaitListManager now stores QuicVersion in the GUID map and sets the
  framer version appropriately using this before sending reset

Merge internal change: 48634592

R=rch@chromium.org

[ramant (doing other things), 2013-07-23 03:01:30]

https://codereview.chromium.org/19858003/diff/18001/net/quic/quic_protocol_te...
File net/quic/quic_protocol_test.cc (right):

https://codereview.chromium.org/19858003/diff/18001/net/quic/quic_protocol_te...
net/quic/quic_protocol_test.cc:74: #if 0
Hi rch,
  chromium doesn't have ScopedMockLog. Should we mock the Logging? (added a TODO
to port ScopedMockLog?).

https://codereview.chromium.org/19858003/diff/18001/net/quic/quic_protocol_te...
net/quic/quic_protocol_test.cc:87: EXPECT_NE(0u, tag);
We return 0 when we do LOG(ERROR).

https://codereview.chromium.org/19858003/diff/18001/net/quic/quic_protocol_te...
net/quic/quic_protocol_test.cc:90: EXPECT_EQ(version,
QuicTagToQuicVersion(tag));
kSupportedQuicVersions shouldn't have QUIC_VERSION_UNSUPPORTED. 

Should I add "EXPECT_NE(QUIC_VERSION_UNSUPPORTED, QuicTagToQuicVersion(tag));"?
thanks.

[Ryan Hamilton, 2013-07-23 03:40:18]

https://codereview.chromium.org/19858003/diff/18001/net/quic/quic_connection_...
File net/quic/quic_connection_test.cc (right):

https://codereview.chromium.org/19858003/diff/18001/net/quic/quic_connection_...
net/quic/quic_connection_test.cc:2266: //// The QUIC_VERSION_X versions are
deliberately set, rather than using all
Is this commented out internally?

https://codereview.chromium.org/19858003/diff/18001/net/quic/quic_framer.cc
File net/quic/quic_framer.cc (right):

https://codereview.chromium.org/19858003/diff/18001/net/quic/quic_framer.cc#n...
net/quic/quic_framer.cc:146: for (size_t i = 0; i <
ARRAYSIZE_UNSAFE(kSupportedQuicVersions); ++i) {
ARRAYSIZE_UNSAFE() vs arraysize()?

https://codereview.chromium.org/19858003/diff/18001/net/quic/quic_protocol_te...
File net/quic/quic_protocol_test.cc (right):

https://codereview.chromium.org/19858003/diff/18001/net/quic/quic_protocol_te...
net/quic/quic_protocol_test.cc:74: #if 0
On 2013/07/23 03:01:30, ramant wrote:
> Hi rch,
>   chromium doesn't have ScopedMockLog. Should we mock the Logging? (added a
TODO
> to port ScopedMockLog?).

Sounds like a good TODO.

https://codereview.chromium.org/19858003/diff/18001/net/quic/quic_protocol_te...
net/quic/quic_protocol_test.cc:87: EXPECT_NE(0u, tag);
On 2013/07/23 03:01:30, ramant wrote:
> We return 0 when we do LOG(ERROR).

Not sure I understand what you mean?  Is this code different from what's in
google3?

https://codereview.chromium.org/19858003/diff/18001/net/quic/quic_protocol_te...
net/quic/quic_protocol_test.cc:90: EXPECT_EQ(version,
QuicTagToQuicVersion(tag));
On 2013/07/23 03:01:30, ramant wrote:
> kSupportedQuicVersions shouldn't have QUIC_VERSION_UNSUPPORTED. 
> 
> Should I add "EXPECT_NE(QUIC_VERSION_UNSUPPORTED,
QuicTagToQuicVersion(tag));"?
> thanks.

Sounds good...

[ramant (doing other things), 2013-07-23 05:05:21]

PTAL. thanks.

https://codereview.chromium.org/19858003/diff/18001/net/quic/quic_connection_...
File net/quic/quic_connection_test.cc (right):

https://codereview.chromium.org/19858003/diff/18001/net/quic/quic_connection_...
net/quic/quic_connection_test.cc:2266: //// The QUIC_VERSION_X versions are
deliberately set, rather than using all
On 2013/07/23 03:40:18, Ryan Hamilton wrote:
> Is this commented out internally?

Yes. It was commented out internally (in the original CL).

https://codereview.chromium.org/19858003/diff/18001/net/quic/quic_framer.cc
File net/quic/quic_framer.cc (right):

https://codereview.chromium.org/19858003/diff/18001/net/quic/quic_framer.cc#n...
net/quic/quic_framer.cc:146: for (size_t i = 0; i <
ARRAYSIZE_UNSAFE(kSupportedQuicVersions); ++i) {
On 2013/07/23 03:40:18, Ryan Hamilton wrote:
> ARRAYSIZE_UNSAFE() vs arraysize()?

Used arraysize() everywhere.
Done.

https://codereview.chromium.org/19858003/diff/18001/net/quic/quic_protocol_te...
File net/quic/quic_protocol_test.cc (right):

https://codereview.chromium.org/19858003/diff/18001/net/quic/quic_protocol_te...
net/quic/quic_protocol_test.cc:87: EXPECT_NE(0u, tag);
On 2013/07/23 03:40:18, Ryan Hamilton wrote:
> On 2013/07/23 03:01:30, ramant wrote:
> > We return 0 when we do LOG(ERROR).
> 
> Not sure I understand what you mean?  Is this code different from what's in
> google3?
> 

I have add line#87. Everything else is same as google3.

https://codereview.chromium.org/19858003/diff/18001/net/quic/quic_protocol_te...
net/quic/quic_protocol_test.cc:90: EXPECT_EQ(version,
QuicTagToQuicVersion(tag));
On 2013/07/23 03:40:18, Ryan Hamilton wrote:
> On 2013/07/23 03:01:30, ramant wrote:
> > kSupportedQuicVersions shouldn't have QUIC_VERSION_UNSUPPORTED. 
> > 
> > Should I add "EXPECT_NE(QUIC_VERSION_UNSUPPORTED,
> QuicTagToQuicVersion(tag));"?
> > thanks.
> 
> Sounds good...

Done.

[Ryan Hamilton, 2013-07-23 05:12:23]

lgtm