* Removed QuicTag kQuicVersion1

net/quic/quic_protocol_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_protocol.h"
 
 #include "base/stl_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
@@ skipping 25 matching lines @@
   InsertMissingPacketsBetween(&received_info, 4u, 10u);
   EXPECT_EQ(6u, received_info.missing_packets.size());
 
   QuicPacketSequenceNumber i = 4;
   for (SequenceNumberSet::iterator it = received_info.missing_packets.begin();
        it != received_info.missing_packets.end(); ++it, ++i) {
     EXPECT_EQ(i, *it);
   }
 }
 
+TEST(QuicProtocolTest, QuicVersionToQuicTag) {
+  // If you add a new version to the QuicVersion enum you will need to add a new
+  // case to QuicVersionToQuicTag, otherwise this test will fail.
+
+  // Explicitly test a specific version.
+  EXPECT_EQ(MakeQuicTag('Q', '0', '0', '6'),
+            QuicVersionToQuicTag(QUIC_VERSION_6));
+
+  // Loop over all supported versions and make sure that we never hit the
+  // default case (i.e. all supported versions should be successfully converted
+  // to valid QuicTags).
+  for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kSupportedQuicVersions); ++i) {
+    const QuicVersion& version = kSupportedQuicVersions[i];
+    EXPECT_LT(0u, QuicVersionToQuicTag(version));
+  }
+}
+
+TEST(QuicProtocolTest, QuicTagToQuicVersion) {
+  // If you add a new version to the QuicVersion enum you will need to add a new
+  // case to QuicTagToQuicVersion, otherwise this test will fail.
+
+  // Explicitly test specific versions.
+  EXPECT_EQ(QUIC_VERSION_6,
+            QuicTagToQuicVersion(MakeQuicTag('Q', '0', '0', '6')));
+  EXPECT_EQ(QUIC_VERSION_UNSUPPORTED,
+            QuicTagToQuicVersion(MakeQuicTag('F', 'A', 'K', 'E')));
+
+  // TODO(rtenneti): Enable checking of Log(ERROR) messages.
+#if 0

[ramant (doing other things), 2013/07/23 03:01:30]

Hi rch,
  chromium doesn't have ScopedMockLog. Should we mock the Logging? (added a TODO
to port ScopedMockLog?).

[Ryan Hamilton, 2013/07/23 03:40:18]

Sounds like a good TODO.

+  // Loop over all supported versions, and make sure we never hit the default
+  // case (which would result in a LOG(ERROR)).
+  ScopedMockLog log(kDoNotCaptureLogsYet);
+  EXPECT_CALL(log, Log(ERROR, _, _)).Times(0);
+  log.StartCapturingLogs();
+#endif
+
+  for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kSupportedQuicVersions); ++i) {
+    const QuicVersion& version = kSupportedQuicVersions[i];
+
+    // Get the tag from the version (we can loop over QuicVersions easily).
+    QuicTag tag = QuicVersionToQuicTag(version);
+    EXPECT_NE(0u, tag);

[ramant (doing other things), 2013/07/23 03:01:30]

We return 0 when we do LOG(ERROR).

[Ryan Hamilton, 2013/07/23 03:40:18]

Not sure I understand what you mean?  Is this code different from what's in
google3?

[ramant (doing other things), 2013/07/23 05:05:22]

I have add line#87. Everything else is same as google3.

+
+    // Now try converting back.
+    EXPECT_EQ(version, QuicTagToQuicVersion(tag));

[ramant (doing other things), 2013/07/23 03:01:30]

kSupportedQuicVersions shouldn't have QUIC_VERSION_UNSUPPORTED. 

Should I add "EXPECT_NE(QUIC_VERSION_UNSUPPORTED, QuicTagToQuicVersion(tag));"?
thanks.

[Ryan Hamilton, 2013/07/23 03:40:18]

Sounds good...

[ramant (doing other things), 2013/07/23 05:05:22]

Done.

+  }
+}
+
+TEST(QuicProtocolTest, QuicVersionToString) {
+  EXPECT_EQ("QUIC_VERSION_6",
+            QuicVersionToString(QUIC_VERSION_6));
+  EXPECT_EQ("QUIC_VERSION_UNSUPPORTED",
+            QuicVersionToString(QUIC_VERSION_UNSUPPORTED));
+
+  QuicVersion single_version[] = {QUIC_VERSION_6};
+  EXPECT_EQ("QUIC_VERSION_6,", QuicVersionArrayToString(single_version,
+                                   ARRAYSIZE_UNSAFE(single_version)));
+  // QuicVersion multiple_versions[] = {QUIC_VERSION_7, QUIC_VERSION_6};
+  // EXPECT_EQ("QUIC_VERSION_7,QUIC_VERSION_6,",
+  //           QuicVersionArrayToString(multiple_versions,
+  //                                    ARRAYSIZE_UNSAFE(multiple_versions)));
+}
+
 }  // namespace
 }  // namespace test
 }  // namespace net