Always check if providers have initial stability metrics.

Always check if providers have initial stability metrics.

Some metrics providers may do work in the HasInitialStabilityMetrics
call that is required for later.  Make sure, for consistency, that
it is always called.

BUG=612073
Committed: https://crrev.com/c35f438fe6e87f4a50e88ccc4952ccd40b77e147
Cr-Commit-Position: refs/heads/master@{#393878}

[bcwhite, 2016-05-16 15:30:00]

bcwhite@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2016-05-16 15:33:16]

If this behavior is important, is it possible to make a unit test for it?

[bcwhite, 2016-05-16 16:59:14]

On 2016/05/16 15:33:16, Alexei Svitkine wrote:
> If this behavior is important, is it possible to make a unit test for it?

Done.

[Alexei Svitkine (slow), 2016-05-16 17:02:31]

lgtm

https://codereview.chromium.org/1985733002/diff/20001/components/metrics/metr...
File components/metrics/metrics_service_unittest.cc (right):

https://codereview.chromium.org/1985733002/diff/20001/components/metrics/metr...
components/metrics/metrics_service_unittest.cc:179:
EXPECT_TRUE(test_provider->has_initial_stability_metrics_called());
Move this to the end of the function and add a comment about it, similar to
what's on line 185 - explaining *why* this behavior is desired, like you do in
the CL description.

[bcwhite, 2016-05-16 17:30:49]

https://codereview.chromium.org/1985733002/diff/20001/components/metrics/metr...
File components/metrics/metrics_service_unittest.cc (right):

https://codereview.chromium.org/1985733002/diff/20001/components/metrics/metr...
components/metrics/metrics_service_unittest.cc:179:
EXPECT_TRUE(test_provider->has_initial_stability_metrics_called());
On 2016/05/16 17:02:31, Alexei Svitkine wrote:
> Move this to the end of the function and add a comment about it, similar to
> what's on line 185 - explaining *why* this behavior is desired, like you do in
> the CL description.

Done.  Though I put it before the other test_provider call-tests so the order of
the tests continues to matche the order in which methods would be called.

[bcwhite, 2016-05-16 17:36:26]

The CQ bit was checked by bcwhite@chromium.org

[bcwhite, 2016-05-16 17:36:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1985733002/#ps40001
(title: "changed order of test expectations")

[commit-bot: I haz the power, 2016-05-16 17:37:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1985733002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1985733002/40001

[commit-bot: I haz the power, 2016-05-16 18:35:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-16 18:38:04]

Description was changed from

==========
Always check if providers have initial stability metrics.

Some metrics providers may do work in the HasInitialStabilityMetrics
call that is required for later.  Make sure, for consistency, that
it is always called.

BUG=612073
==========

to

==========
Always check if providers have initial stability metrics.

Some metrics providers may do work in the HasInitialStabilityMetrics
call that is required for later.  Make sure, for consistency, that
it is always called.

BUG=612073

Committed: https://crrev.com/c35f438fe6e87f4a50e88ccc4952ccd40b77e147
Cr-Commit-Position: refs/heads/master@{#393878}
==========

[commit-bot: I haz the power, 2016-05-16 18:38:05]

Patchset 3 (id:??) landed as
https://crrev.com/c35f438fe6e87f4a50e88ccc4952ccd40b77e147
Cr-Commit-Position: refs/heads/master@{#393878}