Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1985733002: Always check if providers have initial stability metrics. (Closed)

Created:
4 years, 7 months ago by bcwhite
Modified:
4 years, 7 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always check if providers have initial stability metrics. Some metrics providers may do work in the HasInitialStabilityMetrics call that is required for later. Make sure, for consistency, that it is always called. BUG=612073 Committed: https://crrev.com/c35f438fe6e87f4a50e88ccc4952ccd40b77e147 Cr-Commit-Position: refs/heads/master@{#393878}

Patch Set 1 #

Patch Set 2 : added test #

Total comments: 2

Patch Set 3 : changed order of test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M components/metrics/metrics_service.cc View 1 chunk +3 lines, -1 line 0 comments Download
M components/metrics/metrics_service_unittest.cc View 1 2 3 chunks +13 lines, -0 lines 0 comments Download
M components/metrics/test_metrics_provider.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M components/metrics/test_metrics_provider.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
bcwhite
4 years, 7 months ago (2016-05-16 15:30:00 UTC) #2
Alexei Svitkine (slow)
If this behavior is important, is it possible to make a unit test for it?
4 years, 7 months ago (2016-05-16 15:33:16 UTC) #3
bcwhite
On 2016/05/16 15:33:16, Alexei Svitkine wrote: > If this behavior is important, is it possible ...
4 years, 7 months ago (2016-05-16 16:59:14 UTC) #4
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/1985733002/diff/20001/components/metrics/metrics_service_unittest.cc File components/metrics/metrics_service_unittest.cc (right): https://codereview.chromium.org/1985733002/diff/20001/components/metrics/metrics_service_unittest.cc#newcode179 components/metrics/metrics_service_unittest.cc:179: EXPECT_TRUE(test_provider->has_initial_stability_metrics_called()); Move this to the end of the ...
4 years, 7 months ago (2016-05-16 17:02:31 UTC) #5
bcwhite
https://codereview.chromium.org/1985733002/diff/20001/components/metrics/metrics_service_unittest.cc File components/metrics/metrics_service_unittest.cc (right): https://codereview.chromium.org/1985733002/diff/20001/components/metrics/metrics_service_unittest.cc#newcode179 components/metrics/metrics_service_unittest.cc:179: EXPECT_TRUE(test_provider->has_initial_stability_metrics_called()); On 2016/05/16 17:02:31, Alexei Svitkine wrote: > Move ...
4 years, 7 months ago (2016-05-16 17:30:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985733002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985733002/40001
4 years, 7 months ago (2016-05-16 17:37:02 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-16 18:35:32 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 18:38:05 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c35f438fe6e87f4a50e88ccc4952ccd40b77e147
Cr-Commit-Position: refs/heads/master@{#393878}

Powered by Google App Engine
This is Rietveld 408576698