Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: components/metrics/test_metrics_provider.h

Issue 1985733002: Always check if providers have initial stability metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: changed order of test expectations Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/metrics/metrics_service_unittest.cc ('k') | components/metrics/test_metrics_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/test_metrics_provider.h
diff --git a/components/metrics/test_metrics_provider.h b/components/metrics/test_metrics_provider.h
index 6536ea2319864478231f194c4f096773d2463a0f..fd57158d00fc446d3c73cc5293fc4793afef7ce3 100644
--- a/components/metrics/test_metrics_provider.h
+++ b/components/metrics/test_metrics_provider.h
@@ -18,6 +18,7 @@ class TestMetricsProvider : public MetricsProvider {
: init_called_(false),
on_recording_disabled_called_(false),
has_initial_stability_metrics_(false),
+ has_initial_stability_metrics_called_(false),
provide_initial_stability_metrics_called_(false),
provide_stability_metrics_called_(false) {}
@@ -32,6 +33,9 @@ class TestMetricsProvider : public MetricsProvider {
bool init_called() { return init_called_; }
bool on_recording_disabled_called() { return on_recording_disabled_called_; }
+ bool has_initial_stability_metrics_called() {
+ return has_initial_stability_metrics_called_;
+ }
void set_has_initial_stability_metrics(bool has_initial_stability_metrics) {
has_initial_stability_metrics_ = has_initial_stability_metrics;
}
@@ -46,6 +50,7 @@ class TestMetricsProvider : public MetricsProvider {
bool init_called_;
bool on_recording_disabled_called_;
bool has_initial_stability_metrics_;
+ bool has_initial_stability_metrics_called_;
bool provide_initial_stability_metrics_called_;
bool provide_stability_metrics_called_;
« no previous file with comments | « components/metrics/metrics_service_unittest.cc ('k') | components/metrics/test_metrics_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698